Skip to content

Serialise scripts #10866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Serialise scripts #10866

wants to merge 2 commits into from

Conversation

RussKie
Copy link
Member

@RussKie RussKie commented Apr 10, 2023

Proposed changes

  • Rename API RepoDistSettings -> DistributedSettings, RepoDistSettingsPage -> DistributedSettingsPage
  • Allow to distribute user scripts

Screenshots

Before

image

After

image
image

Test methodology

  • TBD

Merge strategy

Don't squash

✒️ I contribute this code under The Developer Certificate of Origin.

@ghost ghost assigned RussKie Apr 10, 2023
@RussKie
Copy link
Member Author

RussKie commented Apr 10, 2023

Reviving an old changeset. I had a quick test, and it seems to work.
@gerhardol @mstv @pmiossec if you could take it for a spin, it'd be great.

@vbjay
Copy link
Contributor

vbjay commented Apr 11, 2023 •
edited
Loading

Recommend guid ids for unique scripts so if same script on multiple layers can get closest to repo setting instead of getting duplicates and instead of using numbers that can colide as different scripts entirely. My 112 global level may be overridden in x repo distributed because number is 112.

If we have a move/copy script around functionality to different layers so a global script has same guid as a distributed in repo then the distributed would win but it would just show 1 script row for the script per level it exists in. Basically overridable scripts.

mstv
mstv reviewed Apr 12, 2023
View reviewed changes
@mstv
Copy link
Member

mstv commented Apr 13, 2023

One needs to select the Scripts settings page once in order to be able to save other settings.
Otherwise:

  • Git Extensions 33.33.33
  • Build f996428
  • Git 2.39.2.windows.1 (recommended: 2.40.0 or later)
  • Microsoft Windows NT 10.0.19045.0
  • .NET 6.0.15
  • DPI 96dpi (no scaling)
System.NullReferenceException: Object reference not set to an instance of an object.
   at GitUI.Script.DistributedScriptsManager.Update(ScriptInfo script) in D:\Build\gitextensions3\GitUI\Script\DistributedScriptsManager.cs:line 177
   at GitUI.CommandsDialogs.SettingsDialog.Pages.ScriptsSettingsPage.PageToSettings() in D:\Build\gitextensions3\GitUI\CommandsDialogs\SettingsDialog\Pages\ScriptsSettingsPage.cs:line 184
   at GitUI.CommandsDialogs.SettingsDialog.SettingsPageBase.SaveSettings() in D:\Build\gitextensions3\GitUI\CommandsDialogs\SettingsDialog\SettingsPageBase.cs:line 99
   at GitUI.CommandsDialogs.FormSettings.Save() in D:\Build\gitextensions3\GitUI\CommandsDialogs\FormSettings.cs:line 236
   at GitUI.CommandsDialogs.FormSettings.Ok_Click(Object sender, EventArgs e) in D:\Build\gitextensions3\GitUI\CommandsDialogs\FormSettings.cs:line 303
   at System.Windows.Forms.Control.OnClick(EventArgs e)
   at System.Windows.Forms.Button.OnClick(EventArgs e)
   at System.Windows.Forms.Button.OnMouseUp(MouseEventArgs mevent)
   at System.Windows.Forms.Control.WmMouseUp(Message& m, MouseButtons button, Int32 clicks)
   at System.Windows.Forms.Control.WndProc(Message& m)
   at System.Windows.Forms.ButtonBase.WndProc(Message& m)
   at System.Windows.Forms.Control.ControlNativeWindow.WndProc(Message& m)
   at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, WM msg, IntPtr wparam, IntPtr lparam)

@mstv
Copy link
Member

mstv commented Apr 13, 2023

The icon combobox dropdown should be filled only once, i.e. if empty.

@RussKie
Copy link
Member Author

RussKie commented Apr 13, 2023 via email •
edited by ghost
Loading

@mstv
Copy link
Member

mstv commented Apr 26, 2023

The sequence of the scripts is not correctly stored or restored.

grafik

@mstv mstv force-pushed the scripts_serialize2 branch from 3f8512a to d280bbc Compare June 28, 2023 21:54
@RussKie RussKie mentioned this pull request Sep 1, 2023
Open
@RussKie RussKie force-pushed the scripts_serialize2 branch from d280bbc to 5076994 Compare October 1, 2023 06:42
This was referenced Oct 4, 2023
Merged
Merged
@RussKie RussKie force-pushed the scripts_serialize2 branch 3 times, most recently from 4f05dca to dcc7cb0 Compare October 12, 2023 22:35
@RussKie RussKie force-pushed the scripts_serialize2 branch from dcc7cb0 to a6d618b Compare April 5, 2025 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mstv mstv mstv left review comments

+1 more reviewer

@vbjay vbjay vbjay left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@RussKie RussKie

Labels
area: settings
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RussKie @vbjay @mstv