Skip to content

Conversation

kgybels
Copy link
Contributor

@kgybels kgybels commented Sep 28, 2016

Same issue as #959 after upgrade to Visual Studio 2015 Update 3.

Paket doesn't like the comments in the file.

Paket failed with:
        Unable to parse C:\git\git-tfs\GitTfs.Vs2015\paket.references
Copy link
Member

@spraints spraints left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. @pmiossec - can you double-check that the paket updates covers everything?

@@ -1,6 +1,2 @@
//If you plan to update this file, you must first absolutly read our documentation on the subject
//because there is some subtleties on how we use it in our project:
//https://github.com/git-tfs/git-tfs/blob/master/doc/paket.md
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you restore the comment in this file?

Copy link
Contributor Author

@kgybels kgybels Sep 29, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do you add comments in paket.references?

I removed them to avoid:
Paket failed with:
Unable to parse C:\git\git-tfs\GitTfs.Vs2015\paket.references

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also would like to keep comments.

Try update your local version of paket.exe because it's perhaps a recent development

I will try myself tonight...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do you add comments in paket.references?

I think @pmiossec just edited the file to add them.

I removed them to avoid:

If it's causing errors, then don't worry about adding it back in.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand better the problem. In fact, we can't add comments in the file. I didn't see well but from the start, we are talking about paket.references and I thought we were talking about paket.dependencies.

Indeed, I had added the comments in the 2 files (things I didn't remember!). The 2nd one without testing :(

There is no real reason to let this comment in this file so I am ok to remove it and to merge the PR.

All is OK!

@spraints spraints merged commit 48207d9 into git-tfs:master Sep 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants