Skip to content

Fix -m for Shelve command, broken by PR #912 #946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 1, 2016
Merged

Fix -m for Shelve command, broken by PR #912 #946

merged 2 commits into from
Apr 1, 2016

Conversation

NathanLBCooper
Copy link
Contributor

Thanks a lot for the pull request you are going to do!
Please verify that you validate these points:

  • indentation is made with 4 spaces
  • your pull request contains only changes intended (no refactoring, line return added, ... that could make code review harder. Make another one if you think it is needed...)
  • run and verify that existing tests pass and add some new units tests, if needed.
  • update the documentation, if needed.
  • update the release notes file

@NathanLBCooper NathanLBCooper mentioned this pull request Apr 1, 2016
Merged
@NathanLBCooper
Copy link
Contributor Author

#912. Tbh, I've not been able to take the time I'd like to understand this code. I'm not sure why exactly I can't get what I need from checkinoptions. But this seems to work.

@spraints
Copy link
Member

spraints commented Apr 1, 2016

LGTM. Thanks!

@spraints spraints merged commit a828a42 into git-tfs:master Apr 1, 2016
@NathanLBCooper
Copy link
Contributor Author

I think I introduced a problem, the git-tfs-work-item stuff isn't getting stripped from the comments. ;_;

@NathanLBCooper NathanLBCooper mentioned this pull request Apr 7, 2016
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NathanLBCooper @spraints @timabell