Add MSI installer #847
Add MSI installer #847
Conversation
|
We need to discuss about that with @spraints because our chocolatey package already provide these features and is easier to build. It will need to do the job twice :-( |
|
an MSI for git tfs seems fine to me. What does the dependency story look like? I think the only chocolatey dep is Git. |
| var ProjectName = "GitTfs"; | ||
| var GUID = new Guid("98823CC2-0C2E-4CF7-B5ED-EA2DD26559BF"); | ||
| var Conf = "Release"; | ||
| #endif |
There was a problem hiding this comment.
Is there a way to do this without a #ifdef? I'd rather avoid preprocessor stuff.
There was a problem hiding this comment.
If this is generated code, please feel free to ignore this comment.
There was a problem hiding this comment.
I'm not aware of any other way to distinguish Debug and Release in code. Anyway why are you against #if DEBUG? Is preprocessor in C# broken?
There was a problem hiding this comment.
I avoid preprocessor conditionals because they make it so that different code is compiled in debug and release. It makes it easier to accidentally add a bug that affects release without noticing the problem in debug.
* adds GitTfs to %PATH% on install and removes on uninstall * supports upgrade * uses WiX#
|
Rebased and updated. I believe #if DEBUG
var IsDebug = true;
#else
var IsDebug = false;
#endif
if (IsDebug) ...is the minimum possible usage of preprocessor. |
1efb109 to
e44e7df
Compare
|
😎 Looks good. |
|
Appveyor doesn't want to add |
|
It seems to generate an exe ( GitTfs.Setup ->
C:\gittfs\GitTfs.Setup\bin\Release\GitTfs.Setup.exe) and you are looking
for a msi to push as artefact...
|
|
|
|
When I made v0.25.0 just now, my build machine said it couldn't find wix. Is there a way to install wix via paket? |
should work (and you will have to commit the 2 packet files updated) |
%PATH%on install and removes on uninstallJust build
GitTfs.Setupproject and MSI file will be in its root folder