Skip to content

Conversation

simpleprovider
Copy link

I updated the commit with more information. The problem is generated by the lib2gitsharp.

…creates the problem. Due to this "changeset.Remote.Repository.GetCommit(changeset.GitCommit).GetTree()" generates paths with "/" instead of "\" like before.
Copy link
Member

@spraints spraints left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(previous iteration was #1296.)

The lib2gitsharp update in the commit 03ecc8c creates the problem.

Did you look to see if this is an expected or documented behavior change in libgit2sharp 0.25?

@simpleprovider
Copy link
Author

I checked their release notes, but I didn't find anything clear about it. There is an open issue libgit2/libgit2sharp#1423 where in the last comment a guy claims the same change of behavior between 24 and 25 versions and fixed the code in
NerdBank.Gitversioning

@siprbaum siprbaum mentioned this pull request Aug 21, 2019
@spraints spraints merged commit 5860b68 into git-tfs:master Aug 21, 2019
@spraints
Copy link
Member

👍 looks like the libgit2sharp change was probably intentional, then. Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants