Not store first commit in global property #1263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The global property `InitialChangeset` is used to store the first changeset the user want to clone from. But this was also in some situations used to store the first changeset of a branch. This cause a problem as this property is global and will be applied to all branches. If `InitialChangeset` is set for a branch, the next cloned branch can not get the changesets before the changeset given this `InitialChangeset` if it is not updated for that branch to. It is problematic to use a property for different information.
6e66017 to
1e043a0
Compare
|
Seems good. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a issue that commits in a branch are lost if they are older then the first commit in a branch that are merging from this branch.
The global property "initial-changeset" is used to store the first changeset the user want to clone from.
But this is allso in some situations used to store the first changeset in a branch. This give a problem as this property is global and will be applied on all branches. If initial-changeset is set for a branch, the next cloned branch can not get the changesets before the changeset given in initial-changeset if it is not updated for that branch to.
It is problematic to use a property for different information.