Skip to content

chore: Add go1.17 for testing #2828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 6, 2021
Merged

chore: Add go1.17 for testing #2828

merged 1 commit into from
Sep 6, 2021

Conversation

appleboy
Copy link
Member

As title

Signed-off-by: Bo-Yi Wu appleboy.tw@gmail.com

@appleboy appleboy added this to the v1.8 milestone Aug 18, 2021
@codecov
Copy link

codecov bot commented Aug 18, 2021 •
edited
Loading

Codecov Report

Merging #2828 (e42fe1b) into master (e4c026e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2828   +/-   ##
=======================================
  Coverage   98.75%   98.75%           
=======================================
  Files          41       41           
  Lines        3054     3054           
=======================================
  Hits         3016     3016           
  Misses         26       26           
  Partials       12       12
Flag Coverage Δ
go-1.13 98.75% <ø> (ø)
go-1.14 98.59% <ø> (ø)
go-1.15 98.59% <ø> (ø)
go-1.16 98.59% <ø> (ø)
go-1.17 98.49% <ø> (?)
macos-latest 98.75% <ø> (ø)
nomsgpack 98.73% <ø> (ø)
ubuntu-latest 98.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4c026e...e42fe1b. Read the comment docs.

@thinkerou
Copy link
Member

error on go 1.17 version:

--- FAIL: TestContextFormFileFailed (0.00s)
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
	panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x18 pc=0x665a92]

goroutine 27 [running]:
testing.tRunner.func1.2({0x9771c0, 0xe883f0})
	/opt/hostedtoolcache/go/1.17.0/x64/src/testing/testing.go:1209 +0x24e
testing.tRunner.func1()
	/opt/hostedtoolcache/go/1.17.0/x64/src/testing/testing.go:1212 +0x218
panic({0x9771c0, 0xe883f0})
	/opt/hostedtoolcache/go/1.17.0/x64/src/runtime/panic.go:1038 +0x215
mime/multipart.(*stickyErrorReader).Read(0xc0003517e0, {0xc0003c7000, 0x0, 0x0})
	/opt/hostedtoolcache/go/1.17.0/x64/src/mime/multipart/multipart.go:127 +0x32
bufio.(*Reader).fill(0xc000343800)
	/opt/hostedtoolcache/go/1.17.0/x64/src/bufio/bufio.go:101 +0x103
bufio.(*Reader).ReadSlice(0xc000343800, 0x60)
	/opt/hostedtoolcache/go/1.17.0/x64/src/bufio/bufio.go:360 +0x2f
mime/multipart.(*Reader).nextPart(0xc00031a380, 0xe8)
	/opt/hostedtoolcache/go/1.17.0/x64/src/mime/multipart/multipart.go:335 +0xb6
mime/multipart.(*Reader).NextPart(...)
	/opt/hostedtoolcache/go/1.17.0/x64/src/mime/multipart/multipart.go:314
mime/multipart.(*Reader).readForm(0xc00014fc00, 0x800000)
	/opt/hostedtoolcache/go/1.17.0/x64/src/mime/multipart/formdata.go:52 +0x178
mime/multipart.(*Reader).ReadForm(...)
	/opt/hostedtoolcache/go/1.17.0/x64/src/mime/multipart/formdata.go:31
net/http.(*Request).ParseMultipartForm(0xc00014fc00, 0xc000052e88)
	/opt/hostedtoolcache/go/1.17.0/x64/src/net/http/request.go:1318 +0xa5
github.com/gin-gonic/gin.(*Context).FormFile(0xc00014fb00, {0x9f7b03, 0x4})
	/home/runner/work/gin/gin/context.go:556 +0x65
github.com/gin-gonic/gin.TestContextFormFileFailed(0x0)
	/home/runner/work/gin/gin/context_test.go:98 +0x285
testing.tRunner(0xc0003c4680, 0xa31170)
	/opt/hostedtoolcache/go/1.17.0/x64/src/testing/testing.go:1259 +0x102
created by testing.(*T).Run
	/opt/hostedtoolcache/go/1.17.0/x64/src/testing/testing.go:1306 +0x35a

@appleboy appleboy mentioned this pull request Sep 3, 2021
Closed
@thinkerou thinkerou mentioned this pull request Sep 5, 2021
Merged
@appleboy appleboy reopened this Sep 6, 2021
@appleboy
chore: Add go1.17 for testing
e42fe1b 
Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
@thinkerou thinkerou self-requested a review September 6, 2021 00:11
thinkerou
thinkerou approved these changes Sep 6, 2021
View reviewed changes
Copy link
Member

@thinkerou thinkerou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@thinkerou thinkerou merged commit a550c56 into master Sep 6, 2021
@appleboy appleboy deleted the go branch September 6, 2021 00:23
thinkerou pushed a commit that referenced this pull request Nov 23, 2021
@appleboy @thinkerou
chore: Add go1.17 for testing (#2828)
77dfd52 
Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
Bisstocuz pushed a commit to Bisstocuz/gin that referenced this pull request Nov 23, 2021
@appleboy @Bisstocuz
chore: Add go1.17 for testing (gin-gonic#2828)
adb4a1f 
Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>

(cherry picked from commit a550c56)
@Bisstocuz Bisstocuz mentioned this pull request Nov 23, 2021
Merged
thinkerou pushed a commit that referenced this pull request Nov 24, 2021
@appleboy @thinkerou
chore: Add go1.17 for testing (#2828)
73501a4 
Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
thinkerou pushed a commit that referenced this pull request Nov 24, 2021
@appleboy @thinkerou
chore: Add go1.17 for testing (#2828)
b052104 
Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
daheige pushed a commit to daheige/gin that referenced this pull request Apr 18, 2022
@appleboy @daheige
chore: Add go1.17 for testing (gin-gonic#2828)
eab2631 
Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thinkerou thinkerou thinkerou approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.
2 participants
@appleboy @thinkerou