Fix Allow header according to RFC 7231 #2476
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2476 +/- ##
=======================================
Coverage 98.64% 98.64%
=======================================
Files 41 41
Lines 1989 1993 +4
=======================================
+ Hits 1962 1966 +4
Misses 15 15
Partials 12 12
Continue to review full report at Codecov.
|
rickb777
reviewed
Oct 23, 2020
| c.writermem.Header()["Allow"] = []string{strings.Join(allowed, ", ")} | ||
| serveError(c, http.StatusMethodNotAllowed, default405Body) | ||
| return | ||
| } | ||
| } | ||
| c.handlers = engine.allNoRoute |
There was a problem hiding this comment.
I'd like a blank line after 455 - a change of subject matter.
|
@antonjah conflicts |
|
I opened a new PR using @unbyte's commits but fixing conflicts, hoping this can get merged & released soon :) |
|
closed PR and move to #3759 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #2397