fix bug in RelativePanel #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seems to be a copy and paste issue, null check is for 1 variable and then it operates on a different property.
|
Hello, |
|
@ghost1372 added PR and opened issues on main repo. |
|
thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
seems to be a copy and paste issue, null check is for 1 variable and then it operates on a different property.
Another issue I noticed, which I tried to fix and fail is:
put panel into vertical alignment = top, horizontal alignment = left...
then have 2 Rectangles in the panel, and the second... alignbottom with panel = true... the panel will fill the area.
In UWP this doesnt happen.
I think the measure pass needs to create the graph and measure the graph in this case... any pointers on how to fix this?