-
Notifications
You must be signed in to change notification settings - Fork 389
Add --std=19 command line option #1981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Currently, all behaviour is the same as for --std=08, except for the standard library search path. No standard libraries exist yet, so running ghdl with --std=19 will fail.
@@ -367,6 +367,8 @@ package body Ghdllocal is | |||
return "v93"; | |||
when Vhdl_08 => | |||
return "v08"; | |||
when Vhdl_19 => |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure how exactly this library compatibility concept works. Should -2019 be compatible with -2008? Is this something that can still easily be decided later?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we can decide later. But I think we need to have dedicated 2019 libraries, as at least std
was extended.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Maybe we want to update the first sentence of the "Main features" section of the README: https://github.com/ghdl/ghdl#main-features.
@@ -503,7 +503,7 @@ package body Vhdl.Sem_Assocs is | |||
if Vhdl02_Assocs_Map (Fmode, Amode) then | |||
return True; | |||
end if; | |||
when Vhdl_08 => | |||
when Vhdl_08 | Vhdl_19 => |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There has been no change to this paragraph in the 2019 LRM.
Done. |
@Xiretza as you still seam to develop on that branch, I marked it as |
No, that was just an accidental push to the wrong branch, which I reverted. Thanks for looking out for that though! |
This is ok for me, but I will first release v2.0 before merging. |
Description
This simply adds the command line option and updates the documentation. There is not yet any difference in simulator behaviour between
--std=08
and--std=19
. Furher, since no 2019 standard library has been added yet,--std=19
can't actually be used outside of bootstrapping.