Skip to content

Conversation

Xiretza
Copy link
Contributor

@Xiretza Xiretza commented Feb 27, 2022

Description

This simply adds the command line option and updates the documentation. There is not yet any difference in simulator behaviour between --std=08 and --std=19. Furher, since no 2019 standard library has been added yet, --std=19 can't actually be used outside of bootstrapping.

Currently, all behaviour is the same as for --std=08, except for the
standard library search path. No standard libraries exist yet, so
running ghdl with --std=19 will fail.
@Xiretza Xiretza mentioned this pull request Feb 27, 2022
46 tasks
@@ -367,6 +367,8 @@ package body Ghdllocal is
return "v93";
when Vhdl_08 =>
return "v08";
when Vhdl_19 =>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how exactly this library compatibility concept works. Should -2019 be compatible with -2008? Is this something that can still easily be decided later?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we can decide later. But I think we need to have dedicated 2019 libraries, as at least std was extended.

Copy link
Member

@umarcor umarcor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Maybe we want to update the first sentence of the "Main features" section of the README: https://github.com/ghdl/ghdl#main-features.

@@ -503,7 +503,7 @@ package body Vhdl.Sem_Assocs is
if Vhdl02_Assocs_Map (Fmode, Amode) then
return True;
end if;
when Vhdl_08 =>
when Vhdl_08 | Vhdl_19 =>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There has been no change to this paragraph in the 2019 LRM.

@umarcor umarcor added Documentation: General General documentation issues. Documentation: Restructured Text Related to documentation written in Restructured Text (ReST). Enhancement FeaReq: VHDL-2019 Requested feature addition related to VHDL-2019. labels Feb 27, 2022
@Xiretza
Copy link
Contributor Author

Xiretza commented Feb 27, 2022

Maybe we want to update the first sentence of the "Main features" section of the README: https://github.com/ghdl/ghdl#main-features.

Done.

@Paebbels Paebbels marked this pull request as draft February 27, 2022 19:13
@Paebbels
Copy link
Member

@Xiretza as you still seam to develop on that branch, I marked it as draft.
You can remove that state, when you're ready.

@Xiretza
Copy link
Contributor Author

Xiretza commented Feb 27, 2022

No, that was just an accidental push to the wrong branch, which I reverted. Thanks for looking out for that though!

@Xiretza Xiretza marked this pull request as ready for review February 27, 2022 19:15
@Paebbels Paebbels requested a review from tgingold February 27, 2022 19:18
@tgingold
Copy link
Member

This is ok for me, but I will first release v2.0 before merging.

@tgingold tgingold merged commit 723a80c into ghdl:master Feb 28, 2022
umarcor added a commit that referenced this pull request Mar 1, 2022
@umarcor umarcor added this to the v3.0 milestone Mar 1, 2022
@Xiretza Xiretza deleted the std-19-flag branch March 12, 2022 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation: General General documentation issues. Documentation: Restructured Text Related to documentation written in Restructured Text (ReST). Enhancement FeaReq: VHDL-2019 Requested feature addition related to VHDL-2019.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants