info: cached info message #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggerganov
approved these changes
Jan 5, 2025
There was a problem hiding this comment.
The llama-server now has the option to filter response fields, so another idea for improvement it to use this feature to minimize the amount of information that is transported from the server to the client, by filtering just the fields that are needed by llama.vim:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of displaying the original response metrics when the completion was pulled from cache, we want to display metrics related to the cache. The completion info is shown in the following format:
C: number of elements currently in the cache / cache size
t: total FIM time
This is what the info message looks like when there is a cache hit.
Changes in this PR:
contentand not the other metrics. This helps reduce the size of the cache.This suggestion was mentioned here: #18 (review)