Skip to content

nix : remove OpenCL remnants #8235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 1, 2024
Merged

nix : remove OpenCL remnants #8235

merged 2 commits into from
Jul 1, 2024

Conversation

ggerganov
Copy link
Member

@ggerganov ggerganov commented Jul 1, 2024 •
edited
Loading

Support for OpenCL was removed recently (#7735)

@ggerganov ggerganov requested a review from SomeoneSerge July 1, 2024 10:50
@github-actions github-actions bot added nix Issues specific to consuming flake.nix, or generally concerned with ❄ Nix-based llama.cpp deployment devops improvements to build systems and github actions labels Jul 1, 2024
SomeoneSerge
SomeoneSerge reviewed Jul 1, 2024
View reviewed changes
.devops/nix/package.nix Outdated
@@ -281,7 +274,7 @@ effectiveStdenv.mkDerivation (
# Configurations we don't want even the CI to evaluate. Results in the
# "unsupported platform" messages. This is mostly a no-op, because
# cudaPackages would've refused to evaluate anyway.
badPlatforms = optionals (useCuda || useOpenCL) lib.platforms.darwin;
badPlatforms = optionals (useCuda) lib.platforms.darwin;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parentheses are now redundant

@ggerganov ggerganov merged commit 257f8e4 into master Jul 1, 2024
MagnusS0 pushed a commit to MagnusS0/llama.cpp-normistral-tokenizer that referenced this pull request Jul 1, 2024
@ggerganov @MagnusS0
nix : remove OpenCL remnants (ggml-org#8235)
f365a45 
* nix : remove OpenCL remnants

* minor : remove parentheses
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Jul 2, 2024
@ggerganov
nix : remove OpenCL remnants (ggml-org#8235)
df078df 
* nix : remove OpenCL remnants

* minor : remove parentheses
okias added a commit to okias/llama.cpp that referenced this pull request Aug 11, 2024
@okias
Revert "ggml : remove OpenCL (ggml-org#7735) + (ggml-org#8235)"
346f64f 
Manually adjusted.

This reverts commit 554c247.
This reverts commit 257f8e4.

Signed-off-by: David Heidelberg <david@ixit.cz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SomeoneSerge SomeoneSerge SomeoneSerge approved these changes

Assignees
No one assigned
Labels
devops improvements to build systems and github actions nix Issues specific to consuming flake.nix, or generally concerned with ❄ Nix-based llama.cpp deployment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ggerganov @SomeoneSerge