Skip to content

hal/vulkan: Clear framebuffer cache during command buffer reset #8031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 30, 2025

Conversation

cwfitzgerald
Copy link
Member

@cwfitzgerald cwfitzgerald commented Jul 30, 2025

Connections

Closes #7847
Spawned #8032

Description

Cache grew without bounds, now that cache is cleared, now there's no leak

Testing

Stared at task manager

Squash or Rebase?

Yes

@cwfitzgerald cwfitzgerald requested a review from a team as a code owner July 30, 2025 23:02
Copy link
Member

@ErichDonGubler ErichDonGubler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This definitely seems preferable to having leaks. Should we maybe have follow-up work to figure out if there's a better way to keep some resources pooled later?

@ErichDonGubler ErichDonGubler self-assigned this Jul 30, 2025
@ErichDonGubler ErichDonGubler added the type: bug Something isn't working label Jul 30, 2025
@ErichDonGubler ErichDonGubler merged commit 58b6135 into gfx-rs:trunk Jul 30, 2025
40 checks passed
@cwfitzgerald
Copy link
Member Author

@ErichDonGubler yup! See the linked issue!

@cwfitzgerald cwfitzgerald deleted the cw/reset-framebuffers branch July 31, 2025 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Leak! Pool of framebuffers in wgpu_hal::vulkan::CommandEncoder grows unbounded
2 participants