Warn/fail if the wrong number of arguments is provided #1342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 5, 2023
hiddeco
reviewed
Dec 15, 2023
When warning, also inform about potentially ignored flags. Signed-off-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Hidde Beydals <hiddeco@users.noreply.github.com> Signed-off-by: Felix Fontein <felix@fontein.de>
hiddeco
approved these changes
Dec 16, 2023
|
@hiddeco thanks for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When warning, also inform about potentially ignored flags.
This improves UX because right now, many users find out that some of their flags are "ignored" (because the CLI library treats them as positional arguments, and sops only uses the first one of them). See for example #1259 or #598.
Either #1274 or this PR needs to be adjusted, whatever is merged first, since this PR is adding a warning for
updatekeys, while that PR allowsupdatekeysto process multiple filenames.