Skip to content

exec-env/exec-file signal handling might be broken #840

@si14

Description

@si14

Hey folks,

We've encountered some issues after we started using exec-file for our software. For example, py.test being run with exec-file inside a docker container would terminate on sigterm immediately, whereas normally it prints test failures first, which is quite annoying.

I'm sorry that I can't provide a minimal reproducing case as we just started exporting secrets before running our process "naked", which solved those problems for us, but after looking through the sources my theory to why that's happening is as follows:

…which sounds similar to the problem someone was having in this blog post https://bigkevmcd.github.io/go/pgrp/context/2019/02/19/terminating-processes-in-go.html

If my understanding is correct, it's a subtle problem for a lot of software using sops. The solution would be for sops to spawn subprocess into a separate process group and pass signals on manually, waiting for the process to finish.

Thank your for your awesome piece of software!

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions