config(slicing) - add slice ID to emitted metrics tags #3374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 27.48% // Head: 91.71% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## sliced-consumers-cli #3374 +/- ##
=========================================================
+ Coverage 27.48% 91.71% +64.23%
=========================================================
Files 663 703 +40
Lines 31234 32305 +1071
=========================================================
+ Hits 8585 29629 +21044
+ Misses 22649 2676 -19973
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
evanh
approved these changes
Nov 11, 2022
ayirr7
added a commit
that referenced
this pull request
Nov 14, 2022
* Create topics class and registry * Rename topic keys to mirror logical values * Move topics list to settings * Add slicing to configuration builder * Add slicing to consumer builder * Add slicing logic to consumer cli * Add slice_id dependent commit log topic * Add clarifying comments * Test changes/add comments * Attempt to rebase * Rename topic keys to mirror logical values * More rebasing * Add cluster selection * Rebase * fix typing * Use cluster selection * fix typing * Remove mutable property of TableWriter * Add slice id parameters where needed * Remove code assuming slice id to be a property of TableWriter * Remove comments * Rename different topics * Remove old comment * Add slice id validation * Tested sliced consumer behavior + get rid of snuba topic mapping * Continuing to rebase * Remove extra newline * add assert to prevent override raw topic + slicing situation * Moving logical to physical topic mapping into KafkaTopicSpec * Add docstring comment for validation * Add test file * Consistent topic handling and resolving * Add test for get_physical_topic_name * Move validation to partitioning file * Fix broken test (get_physical_topic_name) * Remove defaults * Fix mypy issue * Add test * config(slicing) - add slice ID to emitted metrics tags (#3374)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a slice_id tag to all metrics for a consumer if slice_id is present in the CLI flags. This doesn't change run-time behavior.
Before State
There is no way to distinguish metrics across slices without using host info
After State
Consumers passed slice_id will report that as a tag to metrics, to allow for filtering