Revert "ref(MDC): Represent migrations in configuration (#3071)" #3332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not clear that migrations belong in configuration. This was already an issue from the previous work, since the migrations themselves are still part of the code. There is now a separate effort to figure out where migrations should live, so reverting these changes in the mean time to avoid having things in a half finished state. Before state: The generic metrics MigrationGroup was defined in configuration, and the groups code was loading that configuration. The MigrationGroup was a string to allow for groups being defined outside of Python code. After state: All MigrationGroups are defined in the python file, and MigrationGroup has been changed back to an Enum. This reverts commit ae89a81
Codecov ReportBase: 92.32% // Head: 92.29% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #3332 +/- ##
==========================================
- Coverage 92.32% 92.29% -0.04%
==========================================
Files 701 701
Lines 32076 32119 +43
==========================================
+ Hits 29613 29643 +30
- Misses 2463 2476 +13
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
lynnagara
approved these changes
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not clear that migrations belong in configuration. This was already an
issue from the previous work, since the migrations themselves are still part of
the code. There is now a separate effort to figure out where migrations should
live, so reverting these changes in the mean time to avoid having things in a
half finished state.
Before state:
The generic metrics MigrationGroup was defined in configuration, and the groups
code was loading that configuration. The MigrationGroup was a string to allow
for groups being defined outside of Python code.
After state:
All MigrationGroups are defined in the python file, and MigrationGroup has been
changed back to an Enum.
This reverts commit ae89a81
Might cause conflicts with changes from @dbanda @MeredithAnya