ref: use named arguments for drf serializers #53354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4029bf4 to
4431f8d
Compare
asottile-sentry
commented
Jul 21, 2023
src/sentry/scim/endpoints/teams.py
Outdated
| path = serializers.CharField(required=False) | ||
| # TODO: define exact schema for value | ||
| # value = serializers.ListField(child=serializers.DictField(), allow_empty=True) |
There was a problem hiding this comment.
commenting this out since there are several types of requests that happen here -- some with no value, some with value as a map, some with value as a list
when I fixed the named argument it caused the SCIMTeam PATCH tests to fail
JoshFerge
approved these changes
Jul 21, 2023
4431f8d to
c4ffedb
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #53354 +/- ##
==========================================
- Coverage 79.53% 78.21% -1.32%
==========================================
Files 4940 4915 -25
Lines 208111 207911 -200
Branches 35480 35447 -33
==========================================
- Hits 165523 162627 -2896
- Misses 37554 40113 +2559
- Partials 5034 5171 +137
|
JoshFerge
approved these changes
Jul 21, 2023
armenzg
pushed a commit
that referenced
this pull request
Jul 24, 2023
see encode/django-rest-framework#7632 <!-- Describe your PR here. -->
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see encode/django-rest-framework#7632