Skip to content

ref: Remove on_crash hook in favor of event.is_crash() #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
May 25, 2025
Merged

ref: Remove on_crash hook in favor of event.is_crash() #181

merged 10 commits into from
May 25, 2025

Conversation

limbonaut
Copy link
Collaborator

@limbonaut limbonaut commented May 22, 2025 •
edited
Loading

  • Remove on_crash callback, since it is practically the same as before_send.
  • Call before_send for crash events instead.
  • Add SentryEvent.is_crash() method.

Before merge:

  • Update docs

@limbonaut limbonaut linked an issue May 22, 2025 that may be closed by this pull request
Remove on_crash callback in favor of event.is_crash() #178
Closed
@limbonaut limbonaut marked this pull request as ready for review May 22, 2025 18:14
@limbonaut limbonaut force-pushed the ref/remove-on-crash-hook branch from e4863d5 to 2c81366 Compare May 22, 2025 18:19
@limbonaut limbonaut merged commit b7640a5 into main May 25, 2025
21 checks passed
@limbonaut limbonaut deleted the ref/remove-on-crash-hook branch May 25, 2025 09:07
@github-actions GitHub Actions
Copy link
Contributor

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Remove `on_crash` hook in favor of `event.is_crash()` ([#181](https://github.com/getsentry/sentry-godot/pull/181))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 77a28d7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruno-garcia bruno-garcia bruno-garcia approved these changes

@bitsandfoxes bitsandfoxes Awaiting requested review from bitsandfoxes

Assignees
No one assigned
Labels
Breaking Changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove on_crash callback in favor of event.is_crash()
2 participants
@limbonaut @bruno-garcia