Fix missing FailureIssueThreshold and RecoveryThreshold in MonitorConfig JSON serialization #1060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1060 +/- ##
==========================================
+ Coverage 86.86% 86.88% +0.02%
==========================================
Files 55 55
Lines 5840 5842 +2
==========================================
+ Hits 5073 5076 +3
Misses 624 624
+ Partials 143 142 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hi @cleptric! Thanks for merging! Do you have an ETA for the next patch release, or would it be possible to cut a release with this change? This is affecting us in production and I'd like to get the fix out. Happy to help in any way if I can. |
|
Likely next week. |
|
This was released as part of v0.35.0 |
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The checkInMarshalJSON function was missing FailureIssueThreshold and RecoveryThreshold fields when serializing MonitorConfig, causing these values to be omitted from the JSON payload sent to Sentry's API. This results in Sentry using default values instead of the configured values.
This adds the missing fields to the JSON serialization and includes a regression test to prevent future occurrences.
Root Cause:
checkInMarshalJSONininterfaces.gowas not including FailureIssueThreshold and RecoveryThreshold fieldsChanges:
checkInMarshalJSONininterfaces.goto include missing fields in JSON payloadmarshal_test.gowith corresponding golden fileImpact:
Testing:
go test -run TestCheckInEventMarshalJSON- New test passesFixes #1059