Allow flush to be used multiple times #1051
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1051 +/- ##
==========================================
+ Coverage 86.71% 86.86% +0.15%
==========================================
Files 55 55
Lines 5804 5840 +36
==========================================
+ Hits 5033 5073 +40
+ Misses 629 624 -5
- Partials 142 143 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Bug: Race Condition in Start and Flush Methods
A race condition exists between the Flush() and Start() methods. If Flush() is called before the run() goroutine (launched by Start()) has started and reached its select statement, the send operation on the unbuffered flushCh will block indefinitely, leading to a deadlock. This occurs because Start() does not wait for the run() goroutine to be ready to receive.
batch_logger.go#L40-L51
Lines 40 to 51 in 49dd461
Bug: BatchLogger Shutdown Not Triggered on Close
The Client.Close() method fails to shut down the batchLogger's background goroutine, causing a goroutine leak. This occurs because Client.Flush() was modified to no longer terminate the batchLogger, but Client.Close() was not updated to explicitly call client.batchLogger.Shutdown().
client.go#L551-L554
Lines 551 to 554 in 49dd461
Was this report helpful? Give feedback by reacting with 👍 or 👎
Description
Hotfix for flush only being able to be called once.