Skip to content

Add slog fingerprint handler #1039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 18, 2025
Merged

Add slog fingerprint handler #1039

merged 1 commit into from
Jun 18, 2025
+13 −0

Conversation

golemiso
Copy link
Contributor

This pull request introduces support for handling the fingerprint attribute in the slog-to-Sentry event conversion process.

  • Added logic in attrToSentryEvent to recognize the "fingerprint" key and assign its value to the Sentry event's Fingerprint field.
  • Implemented the handleFingerprint function to process the attribute when it is a []string.
  • Added corresponding test cases to ensure correct behavior.

This enhancement allows users to specify custom fingerprints via slog attributes, enabling more flexible event grouping in Sentry.

@golemiso golemiso mentioned this pull request Jun 18, 2025
Merged
@codecov Codecov
Copy link

codecov bot commented Jun 18, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.64%. Comparing base (2837952) to head (c90b79a).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1039      +/-   ##
==========================================
+ Coverage   85.63%   85.64%   +0.01%     
==========================================
  Files          55       55              
  Lines        5526     5532       +6     
==========================================
+ Hits         4732     4738       +6     
  Misses        651      651              
  Partials      143      143

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

giortzisg
giortzisg approved these changes Jun 18, 2025
View reviewed changes
Copy link
Contributor

@giortzisg giortzisg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @golemiso

@giortzisg giortzisg merged commit f28f498 into getsentry:master Jun 18, 2025
16 checks passed
@cleptric cleptric added Feature Issue type labels Jun 18, 2025
@golemiso golemiso deleted the slog-fingerprint branch June 18, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giortzisg giortzisg giortzisg approved these changes

Assignees
No one assigned
Labels
Feature Issue type
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@golemiso @giortzisg @cleptric