Fix remove sentry.origin for sentry logger #1038
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1038 +/- ##
==========================================
- Coverage 85.48% 85.44% -0.05%
==========================================
Files 55 55
Lines 5499 5497 -2
==========================================
- Hits 4701 4697 -4
- Misses 653 655 +2
Partials 145 145 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cleptric
approved these changes
Jun 17, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR removes the sentry.origin attribute from the logger so that origin is only set for integrations, in line with Sentry’s telemetry docs.
- Removed
sentry.originfromlog.gowhen emitting logs. - Updated tests in
log_test.goto no longer expectsentry.origin.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| log.go | Deleted the line setting sentry.origin in log() |
| log_test.go | Removed sentry.origin expectations in three tests |
Comments suppressed due to low confidence (2)
log.go:146
- [nitpick] Add a comment referencing the Sentry telemetry docs (https://develop.sentry.dev/sdk/telemetry/logs/#sdk-integration-attributes) to explain why
sentry.originis omitted for the logger.
attrs["sentry.origin"] = Attribute{Value: "auto.logger.log", Type: "string"}
log_test.go:48
- [nitpick] Consider adding an explicit assertion that
sentry.originis not present in the attributes map to ensure this removal is enforced.
"sentry.sdk.version": {Value: "0.10.0", Type: "string"},
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
According to the docs here https://develop.sentry.dev/sdk/telemetry/logs/#sdk-integration-attributes,
sentry.originshould only be set for integrations.