Add more sensitive headers #1008
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1008 +/- ##
==========================================
+ Coverage 85.41% 85.47% +0.05%
==========================================
Files 55 55
Lines 5486 5486
==========================================
+ Hits 4686 4689 +3
+ Misses 655 653 -2
+ Partials 145 144 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I'm fine with this, but please remove the Python specific comments. |
I've removed all comments in asfaltboy@190dfb7 I also left a backlink to where I snagged these off in sentry-pythong in the PR description. Hopefully that would suffice in the future to help us understand why these headers have been added. |
these should cover more common scenarios
9923335 to
e47aaa5
Compare
|
Hey @cleptric , thanks for correcting the PR and merging it promptly 🙇 Is there an estimated date for the release that this change would land in? |
|
Can't give you an estimate right now. |
These headers should cover a few more headers that are commonly used, with the same method.
Note: this PR does relate to #646 but does not fully "fix it".
The additional headers were mostly copy pasted from the sentry-python SDK, and canonicalized just in case.