Expose MockTransport, MockScope in root sentry package #972
Conversation
Eliminates duplicate implementation in package otel.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #972 +/- ##
==========================================
+ Coverage 83.65% 83.69% +0.04%
==========================================
Files 49 50 +1
Lines 5139 5159 +20
==========================================
+ Hits 4299 4318 +19
- Misses 684 685 +1
Partials 156 156 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Could you fix the lint issue? |
|
@cleptric if only it were that simple — the issue is the repo vars and secrets Excerpt from the workflow run logs: I can locally confirm I'm not introducing any lint issues. $ # On the latest commit of my fork.
$ golangci-lint run ./... --sort-results --max-issues-per-linter=0 --max-same-issues=0 > "$(git rev-parse HEAD).txt"
$
$ # Reset to the merge-base state.
$ git reset --hard HEAD~
$ golangci-lint run ./... --sort-results --max-issues-per-linter=0 --max-same-issues=0 > "$(git rev-parse HEAD).txt"
$
$ # The only difference is a lint issue I *resolve* by deleting mocks_test.go.
$ diff bd1166f6bfd5e3f0841f43fd331df7eeee7e51b4.txt e56ac3010f8c48bbb32839ff8a7e751f420c361f.txt
72a73,75
> mocks_test.go:46:1: File is not properly formatted (gofmt)
>
> ^If you want to verify — the commits in question are bd1166f and e56ac30. Here's a gist of the golangci-lint outputs. |
Uh oh!
There was an error while loading. Please reload this page.