feat: Exclude arm64e slice from Sentry-WithoutUIKitOrAppKit #5897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 55f739c | 1226.06 ms | 1248.78 ms | 22.71 ms |
| c8dd5e4 | 1217.67 ms | 1242.90 ms | 25.23 ms |
| d3e7aa6 | 1226.06 ms | 1248.87 ms | 22.81 ms |
| 65f8d2e | 1221.15 ms | 1243.96 ms | 22.81 ms |
| c2982e7 | 1223.92 ms | 1242.86 ms | 18.94 ms |
| c585b1e | 1232.88 ms | 1249.45 ms | 16.58 ms |
| 0759f32 | 1237.10 ms | 1257.35 ms | 20.25 ms |
| 76f74df | 1238.29 ms | 1261.22 ms | 22.94 ms |
| aa0b738 | 1236.78 ms | 1253.08 ms | 16.31 ms |
| 9389467 | 1218.62 ms | 1244.86 ms | 26.24 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 55f739c | 23.75 KiB | 858.73 KiB | 834.98 KiB |
| c8dd5e4 | 23.75 KiB | 913.48 KiB | 889.72 KiB |
| d3e7aa6 | 23.75 KiB | 913.16 KiB | 889.41 KiB |
| 65f8d2e | 23.74 KiB | 872.67 KiB | 848.93 KiB |
| c2982e7 | 23.75 KiB | 911.62 KiB | 887.87 KiB |
| c585b1e | 23.75 KiB | 879.95 KiB | 856.21 KiB |
| 0759f32 | 23.75 KiB | 880.20 KiB | 856.46 KiB |
| 76f74df | 23.75 KiB | 879.61 KiB | 855.86 KiB |
| aa0b738 | 23.74 KiB | 872.75 KiB | 849.00 KiB |
| 9389467 | 23.75 KiB | 866.51 KiB | 842.76 KiB |
Previous results on branch: itay/cocoa-522-sentry-withoutuikitorappkit-should-omit-arm64e-or-be
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| be5a110 | 1231.96 ms | 1247.94 ms | 15.98 ms |
| 377e618 | 1202.62 ms | 1232.18 ms | 29.56 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| be5a110 | 23.75 KiB | 919.69 KiB | 895.94 KiB |
| 377e618 | 23.75 KiB | 919.69 KiB | 895.94 KiB |
philprime
approved these changes
Aug 13, 2025
…hould-omit-arm64e-or-be
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Excludes ARM64e from Sentry-WithoutUIKitOrAppKit and adds a new variant with ARM64e.
Also updates local script to build these new variants.
Fixes: #5876