ci: Add test for building in keyboard extension with cocoapods #5813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5813 +/- ##
=============================================
+ Coverage 86.642% 86.661% +0.018%
=============================================
Files 423 423
Lines 36339 36405 +66
Branches 17104 17229 +125
=============================================
+ Hits 31485 31549 +64
+ Misses 4809 4808 -1
- Partials 45 48 +3 see 59 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 079bcc8 | 1217.88 ms | 1234.88 ms | 17.00 ms |
| 7b08a87 | 1220.14 ms | 1246.10 ms | 25.96 ms |
| 134fbdf | 1219.71 ms | 1240.35 ms | 20.64 ms |
| d7461dc | 1233.69 ms | 1255.29 ms | 21.60 ms |
| b5a7583 | 1238.22 ms | 1263.94 ms | 25.71 ms |
| 6cb4338 | 1238.47 ms | 1256.96 ms | 18.49 ms |
| db9572a | 1200.27 ms | 1234.80 ms | 34.53 ms |
| 795dd39 | 1216.88 ms | 1245.47 ms | 28.59 ms |
| 42a95d5 | 1206.00 ms | 1224.26 ms | 18.26 ms |
| bce9765 | 1229.42 ms | 1243.49 ms | 14.07 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 079bcc8 | 23.74 KiB | 874.07 KiB | 850.33 KiB |
| 7b08a87 | 23.74 KiB | 913.70 KiB | 889.95 KiB |
| 134fbdf | 23.75 KiB | 875.25 KiB | 851.50 KiB |
| d7461dc | 23.75 KiB | 874.45 KiB | 850.70 KiB |
| b5a7583 | 23.75 KiB | 913.44 KiB | 889.68 KiB |
| 6cb4338 | 23.75 KiB | 913.63 KiB | 889.88 KiB |
| db9572a | 23.75 KiB | 858.69 KiB | 834.93 KiB |
| 795dd39 | 23.75 KiB | 908.16 KiB | 884.41 KiB |
| 42a95d5 | 23.75 KiB | 906.08 KiB | 882.33 KiB |
| bce9765 | 23.74 KiB | 874.06 KiB | 850.32 KiB |
66c4ca6 to
657a836
Compare
noahsmartin
commented
Aug 5, 2025
Samples/iOS-Cocoapods-Swift6/TestKeyboardExtension/KeyboardViewController.swift
Outdated
Show resolved
Hide resolved
|
I leave this PR to @itaybre or @philprime, because you're more involved in the app extension topic and you should be able to give a more meaningful review. |
itaybre
reviewed
Aug 7, 2025
657a836 to
5327d5b
Compare
Samples/iOS-Cocoapods-Swift6/iOS-Cocoapods-Swift6.xcodeproj/project.pbxproj
Show resolved
Hide resolved
Samples/iOS-Cocoapods-Swift6/iOS-Cocoapods-Swift6.xcodeproj/project.pbxproj
Show resolved
Hide resolved
itaybre
approved these changes
Aug 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an app extension to the cocoa pods test app. It fails to build without the other changes in this PR. Mainly, it sets the
APPLICATION_EXTENSION_API_ONLYconfig to NO in the podfile. Without this cocoapods would automatically add it and set it to YES when the framework was linked with app extensions. We can set it to NO and instead add app extension availability flags in the public API, to document to our users that some of our API cannot be called from an app extension.The main reason we need
APPLICATION_EXTENSION_API_ONLY=NOis because the feedback button can be configured to show automatically on SDK start, and that requiresUIApplication.shared. Since that codepath goes through SentrySDK.start() we cannot annotate it withNS_EXTENSION_UNAVAILABLE. We could make another API likeSentrySDK.configureUserFeedbackButton()which is extension unavailable, but the fix in this PR should also work and keep the same public API.#skip-changelog