Skip to content

ci: Fix test race condition #5750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 29, 2025
Merged

ci: Fix test race condition #5750

merged 1 commit into from
Jul 29, 2025

Conversation

noahsmartin
Copy link
Contributor

I saw this timeout in CI

#skip-changelog

@codecov Codecov
Copy link

codecov bot commented Jul 29, 2025 •
edited
Loading

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
31314 2 31312 97
View the top 2 failed test(s) by shortest run time 
SentryTests.SentryHttpTransportFlushIntegrationTests::testFlush_CalledMultipleTimes_ImmediatelyReturnsFalse
Stack Traces | 0s run time 
.../SentryTests/Networking/SentryHttpTransportFlushIntegrationTests.swift:106 - XCTAssertEqual failed: ("SentryFlushResult(rawValue: 1)") is not equal to ("SentryFlushResult(rawValue: 0)")
SentryTracerTests::testConcurrentTransactions_OnlyOneGetsMeasurement
Stack Traces | 0s run time 
Restarting after unexpected exit, crash, or test timeout in SentryTracerTests.testConcurrentTransactions_OnlyOneGetsMeasurement(); summary will include totals from previous launches.

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@itaybre
Copy link
Contributor

itaybre commented Jul 29, 2025

Example timeout: https://github.com/getsentry/sentry-cocoa/actions/runs/16597578417/job/46948104948

philipphofmann
philipphofmann approved these changes Jul 29, 2025
View reviewed changes
Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@noahsmartin noahsmartin merged commit 9add417 into main Jul 29, 2025
47 of 50 checks passed
@noahsmartin noahsmartin deleted the fixTestRaceCondition branch July 29, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itaybre itaybre itaybre approved these changes

@philipphofmann philipphofmann philipphofmann approved these changes

@armcknight armcknight Awaiting requested review from armcknight

@philprime philprime Awaiting requested review from philprime philprime is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@noahsmartin @itaybre @philipphofmann