fix: user feedback events should not be sampled or subject to beforeSend
#5692
+174
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
noahsmartin
approved these changes
Jul 23, 2025
itaybre
reviewed
Jul 23, 2025
Tests/SentryTests/Integrations/Feedback/SentryFeedbackTests.swift
Outdated
Show resolved
Hide resolved
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 2481950 | 1221.04 ms | 1248.98 ms | 27.94 ms |
| a9fac2e | 1212.45 ms | 1219.67 ms | 7.22 ms |
| 99104c9 | 1224.84 ms | 1247.08 ms | 22.24 ms |
| 7148f97 | 1235.09 ms | 1258.07 ms | 22.98 ms |
| 6279992 | 1213.60 ms | 1241.38 ms | 27.79 ms |
| aa96485 | 1215.37 ms | 1234.04 ms | 18.67 ms |
| fc0757d | 1231.83 ms | 1248.98 ms | 17.15 ms |
| 7c7ac56 | 1225.90 ms | 1250.22 ms | 24.33 ms |
| 8e3a42f | 1222.90 ms | 1245.67 ms | 22.77 ms |
| 51f74d7 | 1236.31 ms | 1247.43 ms | 11.12 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 2481950 | 23.74 KiB | 872.74 KiB | 849.00 KiB |
| a9fac2e | 23.75 KiB | 879.53 KiB | 855.78 KiB |
| 99104c9 | 23.75 KiB | 894.83 KiB | 871.09 KiB |
| 7148f97 | 23.75 KiB | 854.78 KiB | 831.03 KiB |
| 6279992 | 23.75 KiB | 891.03 KiB | 867.28 KiB |
| aa96485 | 23.75 KiB | 874.46 KiB | 850.71 KiB |
| fc0757d | 23.75 KiB | 850.73 KiB | 826.98 KiB |
| 7c7ac56 | 23.75 KiB | 902.49 KiB | 878.74 KiB |
| 8e3a42f | 23.75 KiB | 880.06 KiB | 856.31 KiB |
| 51f74d7 | 23.74 KiB | 874.08 KiB | 850.34 KiB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5159 (comment)
Added unit tests that failed before the fix and passed afterwards. Also added a new SDK override for configuring the events sample rate (and reorganized that and the preexisting override to reject events in
beforeSendunder a newEventsoverride enum), and set that as a tag on the scope, and verified that with both overrides configured to reproduce the setup, the user feedback was still received: https://sentry-sdks.sentry.io/issues/feedback/?feedbackSlug=sentry-cocoa%3A6765771740&mailbox=unresolved&project=5428557&referrer=feedback_list_page&statsPeriod=1h