Add beforeSendLog callback to SentryOptions
#5678
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5678 +/- ##
=============================================
+ Coverage 86.655% 86.675% +0.020%
=============================================
Files 423 423
Lines 36405 36505 +100
Branches 17229 17273 +44
=============================================
+ Hits 31547 31641 +94
- Misses 4813 4819 +6
Partials 45 45
... and 8 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
philprime
reviewed
Jul 25, 2025
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 92a02b8 | 1220.89 ms | 1249.27 ms | 28.37 ms |
| 0b5fd21 | 1237.52 ms | 1251.36 ms | 13.84 ms |
| f97a070 | 1218.88 ms | 1253.12 ms | 34.24 ms |
| 55f739c | 1226.06 ms | 1248.78 ms | 22.71 ms |
| 42cfd79 | 1222.13 ms | 1244.23 ms | 22.10 ms |
| 5d238d3 | 1228.94 ms | 1253.04 ms | 24.10 ms |
| 37183fe | 1212.33 ms | 1238.92 ms | 26.59 ms |
| c63e0fe | 1230.58 ms | 1253.94 ms | 23.35 ms |
| d38165b | 1211.41 ms | 1242.49 ms | 31.08 ms |
| db9572a | 1200.27 ms | 1234.80 ms | 34.53 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 92a02b8 | 23.75 KiB | 913.17 KiB | 889.42 KiB |
| 0b5fd21 | 23.75 KiB | 912.78 KiB | 889.03 KiB |
| f97a070 | 23.75 KiB | 858.68 KiB | 834.93 KiB |
| 55f739c | 23.75 KiB | 858.73 KiB | 834.98 KiB |
| 42cfd79 | 23.75 KiB | 880.20 KiB | 856.45 KiB |
| 5d238d3 | 23.75 KiB | 913.62 KiB | 889.88 KiB |
| 37183fe | 23.75 KiB | 913.63 KiB | 889.87 KiB |
| c63e0fe | 23.74 KiB | 874.08 KiB | 850.33 KiB |
| d38165b | 23.75 KiB | 855.37 KiB | 831.62 KiB |
| db9572a | 23.75 KiB | 858.69 KiB | 834.93 KiB |
Previous results on branch: feat/structured-logs-before-send
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| fc721e9 | 1226.10 ms | 1252.48 ms | 26.37 ms |
| 8b314c4 | 1237.20 ms | 1265.29 ms | 28.08 ms |
| a315a86 | 1235.70 ms | 1264.02 ms | 28.33 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| fc721e9 | 23.75 KiB | 919.62 KiB | 895.87 KiB |
| 8b314c4 | 23.74 KiB | 919.50 KiB | 895.76 KiB |
| a315a86 | 23.75 KiB | 913.20 KiB | 889.45 KiB |
beforeSendLog callback to SentryOptions
# Conflicts: # Sources/Swift/Tools/SentryLogger.swift # sdk_api.json # sdk_api_V9.json
denrase
commented
Aug 4, 2025
philprime
reviewed
Aug 4, 2025
noahsmartin
reviewed
Aug 4, 2025
philprime
reviewed
Aug 6, 2025
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#skip-changelog
📜 Description
beforeSendLogcallback toSentryOptionsSentryLogstruct and sub-structures to NSObject for interoperability.SPMbuilds, due to issue with compiling a Swift type in ObjC layer.💡 Motivation and Context
Closes #5668
💚 How did you test it?
Unit tests.
📝 Checklist
You have to check all boxes before merging:
sendDefaultPIIis enabled.