Structured Logs: Add user attributes to logs #5637
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Sources/Sentry/SentryDependencyContainer.m
SentryEnvelope, imported with `@_implementationOnly import _SentryPrivate` is being ‚exposed‘ by SentryLogBatcher as public, even with _spi(Private). Movet the delegate protocol to ObjC to fix this.
itaybre
reviewed
Jul 15, 2025
…ctured-logs-user-attributes # Conflicts: # Sources/Swift/Tools/SentryLogger.swift
philipphofmann
approved these changes
Jul 17, 2025
…ctured-logs-user-attributes
…ctured-logs-user-attributes
…ctured-logs-user-attributes
…ctured-logs-user-attributes
# Conflicts: # Sources/Sentry/include/SentryScope+PrivateSwift.h # Sources/Swift/Tools/SentryLogger.swift # Tests/SentryTests/SentryLoggerTests.swift
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 5ec90e0 | 1235.57 ms | 1258.45 ms | 22.88 ms |
| f92cfa9 | 1228.45 ms | 1251.33 ms | 22.88 ms |
| 5196f0d | 1213.35 ms | 1231.37 ms | 18.02 ms |
| 4e3915a | 1230.02 ms | 1258.90 ms | 28.88 ms |
| 7d23639 | 1237.93 ms | 1243.04 ms | 5.11 ms |
| d637379 | 1226.43 ms | 1250.77 ms | 24.34 ms |
| 63ac649 | 1192.10 ms | 1216.78 ms | 24.68 ms |
| 884b224 | 1233.41 ms | 1259.50 ms | 26.09 ms |
| c63e0fe | 1230.58 ms | 1253.94 ms | 23.35 ms |
| a2a3bfb | 1227.94 ms | 1261.26 ms | 33.32 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 5ec90e0 | 23.74 KiB | 872.67 KiB | 848.92 KiB |
| f92cfa9 | 23.75 KiB | 855.38 KiB | 831.62 KiB |
| 5196f0d | 23.75 KiB | 876.93 KiB | 853.19 KiB |
| 4e3915a | 23.75 KiB | 858.69 KiB | 834.94 KiB |
| 7d23639 | 23.75 KiB | 891.01 KiB | 867.26 KiB |
| d637379 | 23.75 KiB | 855.38 KiB | 831.63 KiB |
| 63ac649 | 23.75 KiB | 855.38 KiB | 831.63 KiB |
| 884b224 | 23.75 KiB | 879.60 KiB | 855.86 KiB |
| c63e0fe | 23.74 KiB | 874.08 KiB | 850.33 KiB |
| a2a3bfb | 23.75 KiB | 872.67 KiB | 848.92 KiB |
# Conflicts: # Sources/Sentry/include/SentryScope+PrivateSwift.h # Sources/Swift/Tools/SentryLogger.swift # Tests/SentryTests/SentryLoggerTests.swift
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#skip-changelog
📜 Description
Structured Logs: Add user attributes
💡 Motivation and Context
Closes #5583
💚 How did you test it?
📝 Checklist
You have to check all boxes before merging:
sendDefaultPIIis enabled.