impr(profiling): continuous chunk serialization off main thread #5613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5613 +/- ##
=============================================
- Coverage 86.483% 86.069% -0.415%
=============================================
Files 415 415
Lines 35291 35268 -23
Branches 15271 14973 -298
=============================================
- Hits 30521 30355 -166
- Misses 4728 4872 +144
+ Partials 42 41 -1
... and 32 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| fd5961e | 1210.59 ms | 1235.57 ms | 24.98 ms |
| 035974f | 1225.89 ms | 1251.23 ms | 25.34 ms |
| 2b02431 | 1229.63 ms | 1248.98 ms | 19.35 ms |
| e0424b9 | 1204.23 ms | 1241.08 ms | 36.85 ms |
| 2481950 | 1221.04 ms | 1248.98 ms | 27.94 ms |
| d05d866 | 1211.78 ms | 1230.96 ms | 19.18 ms |
| e64d3d4 | 1241.90 ms | 1260.10 ms | 18.20 ms |
| acac774 | 1217.76 ms | 1253.29 ms | 35.52 ms |
| 4d264fa | 1223.48 ms | 1246.91 ms | 23.44 ms |
| 884b224 | 1221.11 ms | 1255.88 ms | 34.77 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| fd5961e | 23.74 KiB | 874.07 KiB | 850.32 KiB |
| 035974f | 23.74 KiB | 874.07 KiB | 850.33 KiB |
| 2b02431 | 23.75 KiB | 850.73 KiB | 826.98 KiB |
| e0424b9 | 23.74 KiB | 874.07 KiB | 850.33 KiB |
| 2481950 | 23.74 KiB | 872.74 KiB | 849.00 KiB |
| d05d866 | 23.75 KiB | 878.60 KiB | 854.85 KiB |
| e64d3d4 | 23.75 KiB | 855.37 KiB | 831.62 KiB |
| acac774 | 23.75 KiB | 866.51 KiB | 842.76 KiB |
| 4d264fa | 23.74 KiB | 874.07 KiB | 850.33 KiB |
| 884b224 | 23.75 KiB | 879.55 KiB | 855.80 KiB |
Co-authored-by: Philipp Hofmann <philipp.hofmann@sentry.io>
noahsmartin
approved these changes
Jul 11, 2025
…or main profile data
…le-serialization-off-main-thread
itaybre
reviewed
Jul 11, 2025
itaybre
reviewed
Jul 11, 2025
noahsmartin
approved these changes
Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was pointed out that we're performing JSON serialization of continuous profiling chunks on the main thread. Move it off to a background thread similar to how it was done for transaction profiling in #4377.
Modified a test to ensure the proper queue-based functionality.
I also ran the continuous profiler with the CPU work feature in the benchmarking tab of the iOS-Swift sample app to ensure data is still making it to our backend:
