Skip to content

ref: Extract video processing to a new class #5604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 10, 2025
Merged

ref: Extract video processing to a new class #5604

merged 5 commits into from
Jul 10, 2025

Conversation

itaybre
Copy link
Contributor

@itaybre itaybre commented Jul 10, 2025

Extract video generation to an independent class to enable testing

@codecov Codecov
Copy link

codecov bot commented Jul 10, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 96.50350% with 5 lines in your changes missing coverage. Please review.

Project coverage is 86.482%. Comparing base (cd9727b) to head (50060e4).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...ions/SessionReplay/SentryVideoFrameProcessor.swift 96.153% 4 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #5604       +/-   ##
=============================================
+ Coverage   86.418%   86.482%   +0.063%     
=============================================
  Files          414       415        +1     
  Lines        35262     35280       +18     
  Branches     15261     15304       +43     
=============================================
+ Hits         30473     30511       +38     
+ Misses        4746      4722       -24     
- Partials        43        47        +4
Files with missing lines Coverage Δ
...egrations/SessionReplay/SentryOnDemandReplay.swift 94.230% <100.000%> (+3.426%) ⬆️
...Integrations/SessionReplay/SentryPixelBuffer.swift 88.372% <ø> (ø)
...ions/SessionReplay/SentryVideoFrameProcessor.swift 96.153% <96.153%> (ø)

... and 21 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd9727b...50060e4. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

philipphofmann
philipphofmann approved these changes Jul 10, 2025
View reviewed changes
Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, when removing the duplicate code.

@github-actions GitHub Actions
Copy link
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1217.98 ms 1256.46 ms 38.48 ms
Size 23.75 KiB 879.80 KiB 856.05 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
fc0757d 1231.83 ms 1248.98 ms 17.15 ms
186f06f 1211.33 ms 1235.41 ms 24.08 ms
2a36c3f 1227.27 ms 1246.89 ms 19.63 ms
f92cfa9 1217.94 ms 1240.06 ms 22.12 ms
ccf1278 1226.84 ms 1248.51 ms 21.67 ms
ea5a59b 1222.87 ms 1253.47 ms 30.60 ms
7148f97 1235.09 ms 1258.07 ms 22.98 ms
7908e84 1224.33 ms 1246.39 ms 22.06 ms
2691350 1224.92 ms 1255.82 ms 30.90 ms
b714cb9 1224.71 ms 1238.04 ms 13.33 ms

App size

Revision Plain With Sentry Diff
fc0757d 23.75 KiB 850.73 KiB 826.98 KiB
186f06f 23.75 KiB 876.94 KiB 853.19 KiB
2a36c3f 23.75 KiB 874.45 KiB 850.71 KiB
f92cfa9 23.75 KiB 855.38 KiB 831.63 KiB
ccf1278 23.75 KiB 877.15 KiB 853.40 KiB
ea5a59b 23.75 KiB 874.46 KiB 850.71 KiB
7148f97 23.75 KiB 854.78 KiB 831.03 KiB
7908e84 23.74 KiB 872.75 KiB 849.00 KiB
2691350 23.75 KiB 850.73 KiB 826.98 KiB
b714cb9 23.75 KiB 858.69 KiB 834.93 KiB

@itaybre itaybre merged commit 8e3a42f into main Jul 10, 2025
125 of 126 checks passed
@itaybre itaybre deleted the itay/extract_video_processor branch July 10, 2025 16:19
@antonis antonis mentioned this pull request Jul 31, 2025
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipphofmann philipphofmann philipphofmann approved these changes

@armcknight armcknight Awaiting requested review from armcknight

@philprime philprime Awaiting requested review from philprime philprime is a code owner

@noahsmartin noahsmartin Awaiting requested review from noahsmartin noahsmartin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@itaybre @philipphofmann