Skip to content

feat: Add iOSAppMac and MacCatalyst to app context #5570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 29, 2025
Merged

feat: Add iOSAppMac and MacCatalyst to app context #5570

merged 8 commits into from
Jul 29, 2025

Conversation

philipphofmann
Copy link
Member

@philipphofmann philipphofmann commented Jul 4, 2025 •
edited
Loading

📜 Description

Add info from isiOSAppOnMac and isMacCatalystApp to the runtime context.

💡 Motivation and Context

Fixes GH-4508

💚 How did you test it?

Unit tests.

📝 Checklist

You have to check all boxes before merging:

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

@philipphofmann
feat: Add iOSAppMac and MacCatalyst to app context
c7663cf 
Add two new properties to the app context: isiOSAppOnMac and
isMacCatalystApp.

Fixes GH-4508
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 4, 2025 •
edited
Loading

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against cc91395

@codecov Codecov
Copy link

codecov bot commented Jul 4, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 89.28571% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.629%. Comparing base (ebc72be) to head (cc91395).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
Sources/Sentry/SentryNSProcessInfoWrapper.mm 50.000% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #5570       +/-   ##
=============================================
+ Coverage   86.187%   86.629%   +0.441%     
=============================================
  Files          423       423               
  Lines        36106     36206      +100     
  Branches     15246     17056     +1810     
=============================================
+ Hits         31119     31365      +246     
+ Misses        4944      4557      -387     
- Partials        43       284      +241
Files with missing lines Coverage Δ
...ntryTestUtils/TestSentryNSProcessInfoWrapper.swift 100.000% <100.000%> (ø)
Sources/Sentry/SentryCrashWrapper.m 88.709% <100.000%> (-1.106%) ⬇️
Sources/Sentry/SentryNSProcessInfoWrapper.mm 76.666% <50.000%> (-6.667%) ⬇️

... and 60 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebc72be...cc91395. Read the comment docs.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 4, 2025 •
edited
Loading

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1232.92 ms 1253.45 ms 20.53 ms
Size 23.75 KiB 908.54 KiB 884.79 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
f8029e2 1245.16 ms 1261.32 ms 16.16 ms
2481950 1221.04 ms 1248.98 ms 27.94 ms
15c8cd5 1220.24 ms 1246.14 ms 25.90 ms
e64d3d4 1241.90 ms 1260.10 ms 18.20 ms
fac4ca3 1222.81 ms 1235.83 ms 13.02 ms
51f74d7 1236.31 ms 1247.43 ms 11.12 ms
5c5648e 1234.44 ms 1253.79 ms 19.35 ms
5ec90e0 1235.57 ms 1258.45 ms 22.88 ms
7148f97 1235.09 ms 1258.07 ms 22.98 ms
c63e0fe 1230.58 ms 1253.94 ms 23.35 ms

App size

Revision Plain With Sentry Diff
f8029e2 23.75 KiB 893.72 KiB 869.97 KiB
2481950 23.74 KiB 872.74 KiB 849.00 KiB
15c8cd5 23.75 KiB 908.01 KiB 884.26 KiB
e64d3d4 23.75 KiB 855.37 KiB 831.62 KiB
fac4ca3 23.75 KiB 902.01 KiB 878.27 KiB
51f74d7 23.74 KiB 874.08 KiB 850.34 KiB
5c5648e 23.75 KiB 879.60 KiB 855.86 KiB
5ec90e0 23.74 KiB 872.67 KiB 848.92 KiB
7148f97 23.75 KiB 854.78 KiB 831.03 KiB
c63e0fe 23.74 KiB 874.08 KiB 850.33 KiB

Previous results on branch: feat/add-extra-app-context

Startup times

Revision Plain With Sentry Diff
c256662 1236.10 ms 1261.96 ms 25.86 ms
9041b75 1230.41 ms 1260.12 ms 29.71 ms
03b2c89 1233.90 ms 1256.27 ms 22.37 ms
7a4e0f0 1234.35 ms 1261.90 ms 27.54 ms

App size

Revision Plain With Sentry Diff
c256662 23.75 KiB 908.37 KiB 884.62 KiB
9041b75 23.75 KiB 902.81 KiB 879.06 KiB
03b2c89 23.75 KiB 874.51 KiB 850.77 KiB
7a4e0f0 23.75 KiB 902.83 KiB 879.08 KiB

philprime
philprime approved these changes Jul 4, 2025
View reviewed changes
Copy link
Member

@philprime philprime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, feel free to merge as soon as the TODOs in the PR descriptions are done.

philipphofmann
philipphofmann commented Jul 22, 2025
View reviewed changes
@philipphofmann philipphofmann requested a review from philprime July 22, 2025 09:01
@philipphofmann
Copy link
Member Author

@philprime I changed the solution. Instead of the app context I put the info now onto the runtime context. Please have another look.

philprime
philprime approved these changes Jul 25, 2025
View reviewed changes
Copy link
Member

@philprime philprime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@philipphofmann philipphofmann merged commit 7fc6927 into main Jul 29, 2025
199 of 203 checks passed
@philipphofmann philipphofmann deleted the feat/add-extra-app-context branch July 29, 2025 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philprime philprime philprime approved these changes

@armcknight armcknight Awaiting requested review from armcknight

@noahsmartin noahsmartin Awaiting requested review from noahsmartin noahsmartin is a code owner

@trevor-e trevor-e Awaiting requested review from trevor-e

@itaybre itaybre Awaiting requested review from itaybre itaybre is a code owner

@NicoHinderling NicoHinderling Awaiting requested review from NicoHinderling

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a tag to reflect Catalyst or Designed for iPad
2 participants
@philipphofmann @philprime