feat: Add support for dist and environment fields for termination watch #5560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5560 +/- ##
=============================================
- Coverage 86.335% 86.242% -0.093%
=============================================
Files 407 408 +1
Lines 35157 35189 +32
Branches 15256 15061 -195
=============================================
- Hits 30353 30348 -5
- Misses 4758 4799 +41
+ Partials 46 42 -4
... and 19 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 61414e8 | 1225.49 ms | 1254.28 ms | 28.79 ms |
| d637379 | 1226.43 ms | 1250.77 ms | 24.34 ms |
| 25f2d2c | 1232.02 ms | 1242.78 ms | 10.76 ms |
| 2b02431 | 1229.63 ms | 1248.98 ms | 19.35 ms |
| fc0757d | 1231.83 ms | 1248.98 ms | 17.15 ms |
| 7148f97 | 1235.09 ms | 1258.07 ms | 22.98 ms |
| fc6557e | 1226.40 ms | 1249.88 ms | 23.48 ms |
| 5258fb8 | 1207.92 ms | 1234.51 ms | 26.59 ms |
| fdea6f5 | 1216.08 ms | 1241.82 ms | 25.73 ms |
| e64d3d4 | 1241.90 ms | 1260.10 ms | 18.20 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 61414e8 | 23.75 KiB | 867.69 KiB | 843.94 KiB |
| d637379 | 23.75 KiB | 855.38 KiB | 831.63 KiB |
| 25f2d2c | 23.75 KiB | 866.69 KiB | 842.94 KiB |
| 2b02431 | 23.75 KiB | 850.73 KiB | 826.98 KiB |
| fc0757d | 23.75 KiB | 850.73 KiB | 826.98 KiB |
| 7148f97 | 23.75 KiB | 854.78 KiB | 831.03 KiB |
| fc6557e | 23.75 KiB | 866.68 KiB | 842.93 KiB |
| 5258fb8 | 23.75 KiB | 874.45 KiB | 850.70 KiB |
| fdea6f5 | 23.75 KiB | 867.15 KiB | 843.40 KiB |
| e64d3d4 | 23.75 KiB | 855.37 KiB | 831.62 KiB |
Previous results on branch: itay/cocoa-412-add-missing-information-to-watchdog-termination-events-unified_dist_and_environment
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| b386860 | 1226.69 ms | 1253.14 ms | 26.46 ms |
| de64499 | 1213.98 ms | 1228.79 ms | 14.81 ms |
| 3282670 | 1231.73 ms | 1258.35 ms | 26.62 ms |
| dd4e363 | 1214.21 ms | 1260.09 ms | 45.88 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| b386860 | 23.75 KiB | 878.76 KiB | 855.01 KiB |
| de64499 | 23.74 KiB | 878.87 KiB | 855.12 KiB |
| 3282670 | 23.74 KiB | 879.01 KiB | 855.27 KiB |
| dd4e363 | 23.75 KiB | 878.77 KiB | 855.02 KiB |
d19797d to
8670d28
Compare
philprime
approved these changes
Jul 4, 2025
...ntegrations/WatchdogTerminations/TestSentryWatchdogTerminationAttributesProcessorTests.swift
Outdated
Show resolved
Hide resolved
832e958 to
2942ec3
Compare
Base automatically changed from
itay/cocoa-412-add-missing-information-to-watchdog-termination-events-unified
to
main
July 7, 2025 16:14
…minationFieldsProcessorTests for the new fields
…erminationAttributesProcessor`
4262ae3 to
5ab9258
Compare
|
Confirmed working on testflight: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Dist and Environment to Watchdog Terminated events