Fix crash in file manager #5535
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4bceeec to
06cc7c5
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5535 +/- ##
=============================================
+ Coverage 86.207% 86.279% +0.071%
=============================================
Files 407 407
Lines 35034 35042 +8
Branches 15018 15218 +200
=============================================
+ Hits 30202 30234 +32
+ Misses 4791 4764 -27
- Partials 41 44 +3
... and 16 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
armcknight
approved these changes
Jul 1, 2025
There was a problem hiding this comment.
Looks good, just looks like you need to update some test swift that now can't compile.
Since this modifies a file in HybridPublic I don't know if this is a breaking change or not, will defer to @philipphofmann there.
itaybre
approved these changes
Jul 1, 2025
c10ea7b to
88d50a6
Compare
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| db9572a | 1212.61 ms | 1237.73 ms | 25.13 ms |
| a2a3bfb | 1227.94 ms | 1261.26 ms | 33.32 ms |
| 9389467 | 1218.62 ms | 1244.86 ms | 26.24 ms |
| fdea6f5 | 1216.08 ms | 1241.82 ms | 25.73 ms |
| db9572a | 1223.13 ms | 1241.60 ms | 18.47 ms |
| 701b301 | 1226.10 ms | 1245.57 ms | 19.47 ms |
| 35c962f | 1207.61 ms | 1235.90 ms | 28.29 ms |
| 55f739c | 1226.06 ms | 1248.78 ms | 22.71 ms |
| 2609f7a | 1218.17 ms | 1241.34 ms | 23.17 ms |
| f97a070 | 1218.88 ms | 1253.12 ms | 34.24 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| db9572a | 23.75 KiB | 858.65 KiB | 834.90 KiB |
| a2a3bfb | 23.75 KiB | 872.67 KiB | 848.92 KiB |
| 9389467 | 23.75 KiB | 866.51 KiB | 842.76 KiB |
| fdea6f5 | 23.75 KiB | 867.15 KiB | 843.40 KiB |
| db9572a | 23.75 KiB | 858.64 KiB | 834.89 KiB |
| 701b301 | 23.75 KiB | 867.16 KiB | 843.41 KiB |
| 35c962f | 23.75 KiB | 854.77 KiB | 831.02 KiB |
| 55f739c | 23.75 KiB | 858.73 KiB | 834.98 KiB |
| 2609f7a | 23.75 KiB | 867.04 KiB | 843.29 KiB |
| f97a070 | 23.75 KiB | 858.68 KiB | 834.93 KiB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a crash when SentryFileManager was null. The initializer for SentryFileManager is declared to return a nullable instance, so SentryScopeContextPersistanceStore should be the same. The crash looked like this:
From what I can tell this started crashing since #5242 so hasn't been in production for too long
#skip-changelog