ref: SessionTracker remove observers #5461
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
philprime
reviewed
Jun 23, 2025
| // After stopping the session tracker, we need to set a new hub to the SDK. | ||
| fixture.setNewHubToSDK() | ||
| } | ||
|
|
||
| private func abnormalStopSut() { | ||
| sut.stop(withGracefully: false) | ||
| sut.removeObservers() |
There was a problem hiding this comment.
h: We still need to reset the wasStartSessionCalled, that's why I didn't just remove the observer.
There was a problem hiding this comment.
I don't think so. The tests are all green, cause they all create a new sut. You only need to set wasStartSessionCalled = NO in stop, when you're not getting a new instance.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## philprime/issue-5069 #5461 +/- ##
==========================================================
- Coverage 86.214% 86.086% -0.128%
==========================================================
Files 399 399
Lines 34775 34765 -10
Branches 15078 14882 -196
==========================================================
- Hits 29981 29928 -53
- Misses 4750 4797 +47
+ Partials 44 40 -4
... and 19 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
d5b55b1
into
philprime/issue-5069
124 of 128 checks passed
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 927261d | 1210.24 ms | 1238.59 ms | 28.35 ms |
| b5d1c3d | 1231.00 ms | 1255.47 ms | 24.47 ms |
| bc06793 | 1231.04 ms | 1247.98 ms | 16.94 ms |
| 4deddc5 | 1220.81 ms | 1234.41 ms | 13.60 ms |
| 6996d49 | 1213.72 ms | 1231.27 ms | 17.55 ms |
| 334d6f2 | 1202.65 ms | 1232.21 ms | 29.56 ms |
| 5be643e | 1217.51 ms | 1246.15 ms | 28.64 ms |
| 7ba9cd4 | 1227.26 ms | 1258.63 ms | 31.37 ms |
| 825200b | 1200.16 ms | 1227.76 ms | 27.59 ms |
| 9c7c623 | 1231.18 ms | 1249.28 ms | 18.09 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 927261d | 23.75 KiB | 843.32 KiB | 819.57 KiB |
| b5d1c3d | 23.75 KiB | 841.30 KiB | 817.55 KiB |
| bc06793 | 23.75 KiB | 847.75 KiB | 824.00 KiB |
| 4deddc5 | 23.76 KiB | 822.08 KiB | 798.32 KiB |
| 6996d49 | 23.75 KiB | 847.75 KiB | 824.00 KiB |
| 334d6f2 | 23.75 KiB | 838.54 KiB | 814.79 KiB |
| 5be643e | 23.76 KiB | 820.06 KiB | 796.30 KiB |
| 7ba9cd4 | 23.75 KiB | 847.86 KiB | 824.12 KiB |
| 825200b | 23.75 KiB | 847.90 KiB | 824.15 KiB |
| 9c7c623 | 23.76 KiB | 822.00 KiB | 798.24 KiB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace stop(gracefully) with removeObservers.
This PR is based on #5121 (comment).
#skip-changelog