fix: check correct variables for profiles/traces rand #5447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahsmartin
approved these changes
Jun 20, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5447 +/- ##
=============================================
- Coverage 86.070% 86.000% -0.070%
=============================================
Files 399 398 -1
Lines 34553 34538 -15
Branches 14894 14828 -66
=============================================
- Hits 29740 29703 -37
- Misses 4766 4792 +26
+ Partials 47 43 -4
... and 19 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c319795 | 1205.12 ms | 1231.20 ms | 26.08 ms |
| eea25a8 | 1240.54 ms | 1262.69 ms | 22.15 ms |
| 94e1968 | 1218.20 ms | 1230.57 ms | 12.37 ms |
| e5a239a | 1225.65 ms | 1249.21 ms | 23.56 ms |
| 0538fb6 | 1218.35 ms | 1241.36 ms | 23.01 ms |
| 18d491a | 1226.86 ms | 1251.35 ms | 24.49 ms |
| 97e82fe | 1230.71 ms | 1249.67 ms | 18.97 ms |
| c2acec5 | 1200.60 ms | 1227.08 ms | 26.48 ms |
| b380503 | 1207.23 ms | 1220.02 ms | 12.79 ms |
| df50619 | 1226.11 ms | 1244.92 ms | 18.81 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c319795 | 20.76 KiB | 431.99 KiB | 411.22 KiB |
| eea25a8 | 22.31 KiB | 771.26 KiB | 748.94 KiB |
| 94e1968 | 21.58 KiB | 614.73 KiB | 593.15 KiB |
| e5a239a | 21.58 KiB | 713.49 KiB | 691.91 KiB |
| 0538fb6 | 21.58 KiB | 683.50 KiB | 661.92 KiB |
| 18d491a | 21.58 KiB | 544.86 KiB | 523.28 KiB |
| 97e82fe | 21.58 KiB | 655.90 KiB | 634.32 KiB |
| c2acec5 | 22.85 KiB | 408.88 KiB | 386.03 KiB |
| b380503 | 22.31 KiB | 821.42 KiB | 799.11 KiB |
| df50619 | 21.58 KiB | 671.57 KiB | 649.99 KiB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed while adding more edge case tests to #5318 that these checks were copypasta'd and not checking the correct variable contents, first introduced in #4751