fix: Stacktrace symbolication of fatal app hangs #5438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add debug images for all app hang events directly in the ANRTrackingIntegration to ensure all app hang events have debug images attached, which is required for symbolication. Fixes GH-5433
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5438 +/- ##
=============================================
- Coverage 86.217% 86.214% -0.003%
=============================================
Files 399 399
Lines 34652 34652
Branches 14991 14986 -5
=============================================
- Hits 29876 29875 -1
Misses 4734 4734
- Partials 42 43 +1
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 9faf217 | 1268.86 ms | 1274.82 ms | 5.96 ms |
| b5bcbab | 1222.24 ms | 1243.20 ms | 20.96 ms |
| b1b7d72 | 1246.31 ms | 1261.00 ms | 14.69 ms |
| 83acf3e | 1240.06 ms | 1261.38 ms | 21.31 ms |
| 8ef07fb | 1231.45 ms | 1243.98 ms | 12.53 ms |
| a9103fe | 1221.49 ms | 1243.33 ms | 21.84 ms |
| 7f691b5 | 1233.94 ms | 1243.80 ms | 9.86 ms |
| 81c2187 | 1224.20 ms | 1252.68 ms | 28.48 ms |
| 676e429 | 1225.76 ms | 1235.49 ms | 9.73 ms |
| 7054676 | 1229.46 ms | 1246.40 ms | 16.94 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 9faf217 | 20.76 KiB | 419.70 KiB | 398.94 KiB |
| b5bcbab | 23.75 KiB | 846.99 KiB | 823.24 KiB |
| b1b7d72 | 20.76 KiB | 436.33 KiB | 415.57 KiB |
| 83acf3e | 21.58 KiB | 539.87 KiB | 518.29 KiB |
| 8ef07fb | 21.58 KiB | 707.42 KiB | 685.84 KiB |
| a9103fe | 20.76 KiB | 426.95 KiB | 406.19 KiB |
| 7f691b5 | 20.76 KiB | 420.55 KiB | 399.79 KiB |
| 81c2187 | 21.58 KiB | 736.53 KiB | 714.94 KiB |
| 676e429 | 21.58 KiB | 614.73 KiB | 593.15 KiB |
| 7054676 | 21.58 KiB | 542.28 KiB | 520.70 KiB |
itaybre
approved these changes
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Add debug images for all app hang events directly in the ANRTrackingIntegration to ensure all app hang events have debug images attached, which is required for symbolication.
💡 Motivation and Context
Fixes GH-5433
💚 How did you test it?
Unit tests and with TestFlight
Fatal app hang event before the fix from the iOS-Swift sample app via TestFlight
https://sentry-sdks.sentry.io/issues/6690874496/events/da915f043c0741959b04d9ce9ba42943/?project=5428557
With the fix
https://sentry-sdks.sentry.io/issues/6695548079/events/934bb93490554023905e9570cc78c75a/?project=5428557
📝 Checklist
You have to check all boxes before merging:
sendDefaultPIIis enabled.