fix(profiling): check previous options for launch profiles #5417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ting all options from persistence; using the hydrated options instead of new options which may have changed
… trace profiles but was setting up continuous!
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5417 +/- ##
=============================================
+ Coverage 86.449% 86.473% +0.023%
=============================================
Files 417 418 +1
Lines 35424 35531 +107
Branches 15145 15391 +246
=============================================
+ Hits 30624 30725 +101
- Misses 4759 4765 +6
Partials 41 41
... and 18 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| a2a3bfb | 1227.94 ms | 1261.26 ms | 33.32 ms |
| 8ad303c | 1220.02 ms | 1231.79 ms | 11.77 ms |
| 2691350 | 1224.92 ms | 1255.82 ms | 30.90 ms |
| f92cfa9 | 1228.45 ms | 1251.33 ms | 22.88 ms |
| 7908e84 | 1224.33 ms | 1246.39 ms | 22.06 ms |
| acac774 | 1217.76 ms | 1253.29 ms | 35.52 ms |
| cc7f629 | 1226.00 ms | 1245.51 ms | 19.51 ms |
| 2a36c3f | 1227.27 ms | 1246.89 ms | 19.63 ms |
| 4d264fa | 1223.48 ms | 1246.91 ms | 23.44 ms |
| 5196f0d | 1213.35 ms | 1231.37 ms | 18.02 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| a2a3bfb | 23.75 KiB | 872.67 KiB | 848.92 KiB |
| 8ad303c | 23.75 KiB | 879.24 KiB | 855.49 KiB |
| 2691350 | 23.75 KiB | 850.73 KiB | 826.98 KiB |
| f92cfa9 | 23.75 KiB | 855.38 KiB | 831.62 KiB |
| 7908e84 | 23.74 KiB | 872.75 KiB | 849.00 KiB |
| acac774 | 23.75 KiB | 866.51 KiB | 842.76 KiB |
| cc7f629 | 23.75 KiB | 878.48 KiB | 854.73 KiB |
| 2a36c3f | 23.75 KiB | 874.45 KiB | 850.71 KiB |
| 4d264fa | 23.74 KiB | 874.07 KiB | 850.33 KiB |
| 5196f0d | 23.75 KiB | 876.93 KiB | 853.19 KiB |
Previous results on branch: armckngiht/fix/check-previous-options-ttfd-launch-profiles
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e363fc9 | 1227.41 ms | 1250.64 ms | 23.23 ms |
| c62431d | 1229.37 ms | 1254.51 ms | 25.14 ms |
| 6f69e49 | 1235.20 ms | 1260.51 ms | 25.31 ms |
| 7778e26 | 1201.77 ms | 1223.18 ms | 21.41 ms |
| 1d95f93 | 1243.08 ms | 1262.59 ms | 19.51 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e363fc9 | 23.75 KiB | 880.35 KiB | 856.60 KiB |
| c62431d | 23.75 KiB | 880.35 KiB | 856.60 KiB |
| 6f69e49 | 23.75 KiB | 875.96 KiB | 852.21 KiB |
| 7778e26 | 23.75 KiB | 881.25 KiB | 857.50 KiB |
| 1d95f93 | 23.75 KiB | 881.35 KiB | 857.60 KiB |
… continuous v1; forgot to clean up config file if shouldWaitForFullDisplayValue was missing
…lDisplay by making the launch tracer the parent of the perf tracker span if one is running
noahsmartin
reviewed
Jul 8, 2025
…nd also add logic to SentrySDK.stopProfiler that checks the hydrated options if the current profiler is a launch profiler
…previous-options-ttfd-launch-profiles
armcknight
commented
Jul 10, 2025
…previous-options-ttfd-launch-profiles
…previous-options-ttfd-launch-profiles
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
noahsmartin
approved these changes
Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #5327
I noticed while reviewing #5300 that we mix persisted and current options when looking at conditions to stop launch profiles, specifically w.r.t. TTID/TTFD.