fix(session-replay): Add redaction for SFSafariView #5408
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5408 +/- ##
=============================================
+ Coverage 86.022% 86.031% +0.009%
=============================================
Files 399 399
Lines 34621 34629 +8
Branches 14974 14995 +21
=============================================
+ Hits 29782 29792 +10
+ Misses 4797 4794 -3
- Partials 42 43 +1
... and 7 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 17afc4b | 1228.94 ms | 1251.10 ms | 22.16 ms |
| ebeb68c | 1216.27 ms | 1243.80 ms | 27.53 ms |
| 01a28a9 | 1225.55 ms | 1249.96 ms | 24.41 ms |
| fb53d97 | 1235.00 ms | 1241.88 ms | 6.88 ms |
| 245f981 | 1228.65 ms | 1248.76 ms | 20.11 ms |
| 3723833 | 1205.22 ms | 1216.94 ms | 11.71 ms |
| b055f7b | 1232.90 ms | 1247.65 ms | 14.75 ms |
| 7cd187e | 1243.04 ms | 1244.79 ms | 1.75 ms |
| dd34512 | 1221.45 ms | 1251.23 ms | 29.77 ms |
| 72f0262 | 1239.84 ms | 1258.42 ms | 18.59 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 17afc4b | 20.76 KiB | 436.25 KiB | 415.49 KiB |
| ebeb68c | 21.58 KiB | 698.37 KiB | 676.79 KiB |
| 01a28a9 | 22.85 KiB | 405.39 KiB | 382.55 KiB |
| fb53d97 | 20.76 KiB | 425.80 KiB | 405.04 KiB |
| 245f981 | 23.75 KiB | 847.17 KiB | 823.42 KiB |
| 3723833 | 21.58 KiB | 424.34 KiB | 402.76 KiB |
| b055f7b | 23.75 KiB | 840.58 KiB | 816.83 KiB |
| 7cd187e | 20.76 KiB | 401.65 KiB | 380.89 KiB |
| dd34512 | 23.76 KiB | 869.05 KiB | 845.29 KiB |
| 72f0262 | 21.58 KiB | 418.14 KiB | 396.56 KiB |
Previous results on branch: kw-fix-safari-view-redaction
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 8ef582f | 1233.71 ms | 1257.56 ms | 23.85 ms |
| b7f52f8 | 1222.65 ms | 1240.54 ms | 17.89 ms |
| c78b91b | 1235.33 ms | 1247.79 ms | 12.46 ms |
| bb4b506 | 1241.00 ms | 1251.98 ms | 10.98 ms |
| 82da6d1 | 1205.81 ms | 1232.00 ms | 26.19 ms |
| 3644101 | 1219.80 ms | 1239.54 ms | 19.75 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 8ef582f | 23.75 KiB | 847.02 KiB | 823.28 KiB |
| b7f52f8 | 23.75 KiB | 847.02 KiB | 823.27 KiB |
| c78b91b | 23.75 KiB | 847.02 KiB | 823.28 KiB |
| bb4b506 | 23.75 KiB | 846.85 KiB | 823.11 KiB |
| 82da6d1 | 23.75 KiB | 847.02 KiB | 823.28 KiB |
| 3644101 | 23.75 KiB | 847.02 KiB | 823.27 KiB |
c3f45c3 to
da1944e
Compare
|
Thank you for the PR. I'll take over here and make sure we have an example in the sample apps and tests/verification |
|
philprime
approved these changes
Jun 16, 2025
|
I manually tested the redaction for iOS 16, 17 and 18. |
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- Add redaction for SFSafariView ([#5408](https://github.com/getsentry/sentry-cocoa/pull/5408))If none of the above apply, you can opt out of this check by adding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
SFSafariView doesn't use WebView component and thus is not redacted with the current set of classes to redact.
💡 Motivation and Context
fixes: getsentry/sentry-react-native#4920
💚 How did you test it?
tested with adjusted reproducible example: https://github.com/krystofwoldrich/expo-auth-session-sentry
example of replay before this pr: https://krystof-woldrich.sentry.io/explore/replays/9d5c14e2372c4d4ca23e6238bdf63aa9
example of replay after this pr: https://krystof-woldrich.sentry.io/explore/replays/7b883d4d68594c06a4869884788b4e9c
📝 Checklist
You have to check all boxes before merging:
sendDefaultPIIis enabled.