Skip to content

ref: Convert SentryUserFeedback to Swift #5377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 9, 2025
Merged

ref: Convert SentryUserFeedback to Swift #5377

merged 5 commits into from
Jun 9, 2025

Conversation

noahsmartin
Copy link
Contributor

📜 Description

Convert this objc class to Swift

💡 Motivation and Context

It's the easiest way to get it working with SPM since the file is small enough to be fully converted

💚 How did you test it?

Build + CI tests

📝 Checklist

You have to check all boxes before merging:

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

@codecov Codecov
Copy link

codecov bot commented Jun 6, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.048%. Comparing base (fc000c8) to head (dd5749a).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #5377       +/-   ##
=============================================
+ Coverage   86.013%   86.048%   +0.035%     
=============================================
  Files          397       397               
  Lines        34590     34584        -6     
  Branches     14979     14973        -6     
=============================================
+ Hits         29752     29759        +7     
+ Misses        4796      4785       -11     
+ Partials        42        40        -2
Files with missing lines Coverage Δ
Sources/Sentry/SentryClient.m 98.459% <ø> (ø)
Sources/Sentry/SentryEnvelope.m 89.320% <ø> (ø)
Sources/Sentry/SentryTransportAdapter.m 100.000% <ø> (ø)
...Integrations/UserFeedback/SentryUserFeedback.swift 100.000% <100.000%> (ø)

... and 8 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc000c8...dd5749a. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 6, 2025 •
edited
Loading

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1229.86 ms 1248.67 ms 18.82 ms
Size 23.75 KiB 842.69 KiB 818.95 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
e4cc043 1230.10 ms 1254.36 ms 24.26 ms
103d817 1211.55 ms 1213.35 ms 1.80 ms
983de17 1260.57 ms 1263.68 ms 3.11 ms
e070f8a 1236.47 ms 1250.50 ms 14.03 ms
afce5bf 1199.94 ms 1213.27 ms 13.33 ms
b9b0f0a 1257.22 ms 1262.57 ms 5.35 ms
60bfc91 1251.29 ms 1261.67 ms 10.39 ms
3fc6a6f 1241.96 ms 1254.13 ms 12.17 ms
6e625c5 1243.47 ms 1243.58 ms 0.11 ms
2deb275 1228.20 ms 1245.02 ms 16.82 ms

App size

Revision Plain With Sentry Diff
e4cc043 22.85 KiB 414.92 KiB 392.07 KiB
103d817 21.58 KiB 571.91 KiB 550.33 KiB
983de17 22.84 KiB 403.19 KiB 380.34 KiB
e070f8a 21.58 KiB 546.20 KiB 524.62 KiB
afce5bf 21.58 KiB 542.18 KiB 520.60 KiB
b9b0f0a 20.76 KiB 434.94 KiB 414.17 KiB
60bfc91 20.76 KiB 434.94 KiB 414.18 KiB
3fc6a6f 22.30 KiB 821.37 KiB 799.07 KiB
6e625c5 22.85 KiB 413.41 KiB 390.56 KiB
2deb275 21.58 KiB 681.72 KiB 660.14 KiB

Previous results on branch: convertUserFeedback

Startup times

Revision Plain With Sentry Diff
a3c69b2 1238.42 ms 1265.04 ms 26.62 ms
056be20 1238.82 ms 1263.76 ms 24.94 ms
f3bdbf2 1210.25 ms 1232.22 ms 21.97 ms
6f80b7a 1226.30 ms 1247.69 ms 21.38 ms

App size

Revision Plain With Sentry Diff
a3c69b2 23.75 KiB 842.67 KiB 818.92 KiB
056be20 23.75 KiB 842.27 KiB 818.52 KiB
f3bdbf2 23.75 KiB 842.27 KiB 818.53 KiB
6f80b7a 23.75 KiB 842.69 KiB 818.94 KiB

@noahsmartin noahsmartin force-pushed the convertUserFeedback branch from 202f96a to d790890 Compare June 7, 2025 00:45
@noahsmartin noahsmartin force-pushed the convertUserFeedback branch from d790890 to 4456dfc Compare June 8, 2025 18:51
armcknight
armcknight approved these changes Jun 9, 2025
View reviewed changes
Copy link
Member

@armcknight armcknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@noahsmartin noahsmartin merged commit 9aa0b44 into main Jun 9, 2025
93 of 96 checks passed
@noahsmartin noahsmartin deleted the convertUserFeedback branch June 9, 2025 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@armcknight armcknight armcknight approved these changes

@philipphofmann philipphofmann Awaiting requested review from philipphofmann philipphofmann is a code owner

@philprime philprime Awaiting requested review from philprime philprime is a code owner

@trevor-e trevor-e Awaiting requested review from trevor-e

@itaybre itaybre Awaiting requested review from itaybre itaybre is a code owner

@NicoHinderling NicoHinderling Awaiting requested review from NicoHinderling

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noahsmartin @armcknight