fix: Missing debug meta for non fatal events #5352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5352 +/- ##
=============================================
- Coverage 85.981% 85.974% -0.007%
=============================================
Files 394 394
Lines 34190 34217 +27
Branches 14773 14790 +17
=============================================
+ Hits 29397 29418 +21
- Misses 4752 4759 +7
+ Partials 41 40 -1
... and 7 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 995c3cb | 1215.41 ms | 1231.15 ms | 15.74 ms |
| c0c1496 | 1201.19 ms | 1228.36 ms | 27.17 ms |
| 8aba9c4 | 1236.94 ms | 1248.29 ms | 11.35 ms |
| 2911760 | 1217.84 ms | 1232.48 ms | 14.64 ms |
| 25d925a | 1232.89 ms | 1248.41 ms | 15.52 ms |
| bd8b1bf | 1228.94 ms | 1251.19 ms | 22.25 ms |
| dd0557f | 1251.82 ms | 1256.76 ms | 4.94 ms |
| 2af280d | 1232.31 ms | 1249.98 ms | 17.67 ms |
| f1e2aa7 | 1239.31 ms | 1259.08 ms | 19.78 ms |
| 3cba0e8 | 1250.86 ms | 1258.39 ms | 7.53 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 995c3cb | 22.85 KiB | 412.66 KiB | 389.81 KiB |
| c0c1496 | 22.85 KiB | 407.45 KiB | 384.60 KiB |
| 8aba9c4 | 21.58 KiB | 544.72 KiB | 523.14 KiB |
| 2911760 | 21.58 KiB | 697.69 KiB | 676.11 KiB |
| 25d925a | 21.58 KiB | 418.82 KiB | 397.24 KiB |
| bd8b1bf | 22.32 KiB | 761.25 KiB | 738.93 KiB |
| dd0557f | 22.85 KiB | 411.75 KiB | 388.91 KiB |
| 2af280d | 20.76 KiB | 435.22 KiB | 414.46 KiB |
| f1e2aa7 | 22.31 KiB | 768.52 KiB | 746.21 KiB |
| 3cba0e8 | 22.84 KiB | 403.19 KiB | 380.34 KiB |
GH-5225 introduced a bug so that nonfatal events have missing debug_meta, leading to redacted stacktraces. Fatal events such as crashes aren't impacted by this bug. The root cause was that the initializers of specific classes were getting initialized in the SentryDependencyContainer, which also accessed the shared instance of the SentryDependencyContainer, causing a chicken-egg problem. This is fixed now by removing the usage of SentryDependencyContainer of the dependencies initialized in SentryDependencyContainer.init. Furthermore, the SentryDependencyContainer now uses SENTRY_GRACEFUL_FATAL to exit the application in debug and log a warning in production.
36d15b4 to
b56ec31
Compare
philprime
approved these changes
Jun 4, 2025
|
The UI test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
GH-5225 introduced a bug so that nonfatal events have missing debug_meta, leading to redacted stacktraces. Fatal events such as crashes aren't impacted by this bug. The root cause was that the initializers of specific classes were getting initialized in the SentryDependencyContainer, which also accessed the shared instance of the SentryDependencyContainer, causing a chicken-egg problem. This is fixed now by removing the usage of SentryDependencyContainer of the dependencies initialized in SentryDependencyContainer.init. Furthermore, the SentryDependencyContainer now uses SENTRY_GRACEFUL_FATAL to exit the application in debug and log a warning in production.
Doc PRs for the troubleshooting guide: getsentry/sentry-docs#13921
fixes #5334
💡 Motivation and Context
Surfaced by a customer
💚 How did you test it?
Manually with a TestFlight build.
Capture Message now again has a proper stacktrace with a symbolicated event.
And also debug_meta
✅ Capture message event: https://sentry-sdks.sentry.io/issues/6656660577/events/5c8be3a04b5543ad947b9dec11c3c730/?project=5428557
✅ And custom exception: https://sentry-sdks.sentry.io/issues/2862440042/events/4782ca3b17764e14a18a80e7a036e42f/?project=5428557
✅ Crash event: https://sentry-sdks.sentry.io/issues/6044162827/events/f8d75320310141bb8be1dd8d1ee193fb/?project=5428557
✅ Fatal error: https://sentry-sdks.sentry.io/issues/6536640165/events/1ff359d033204a4cb668e1cff4da7ea7/?project=5428557
We are going to add an integration test after the hotfix.
📝 Checklist
You have to check all boxes before merging:
sendDefaultPIIis enabled.