ref: Add more metrics and producer_name tag #479
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ref STREAM-324 See getsentry/relay#5031 for context
fpacifici
reviewed
Aug 7, 2025
| @@ -111,10 +199,15 @@ def build_kafka_producer_configuration( | |||
| default_config, bootstrap_servers, override_params | |||
| ) | |||
|
|
|||
| # Extract client.id to use as producer name for metrics | |||
| producer_name = broker_config.get("client.id") | |||
There was a problem hiding this comment.
the idea is that we let the user configure rdkafka's client.id (since they are already responsible for coming up with a kafka producer config) and then use that as a tag.
fpacifici
approved these changes
Aug 7, 2025
untitaker
added a commit
to getsentry/sentry
that referenced
this pull request
Aug 13, 2025
ref STREAM-324 see getsentry/arroyo#479 and getsentry/relay#5031 --------- Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>
priscilawebdev
pushed a commit
to getsentry/sentry
that referenced
this pull request
Aug 25, 2025
ref STREAM-324 see getsentry/arroyo#479 and getsentry/relay#5031 --------- Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref STREAM-324
See getsentry/relay#5031 for context