fix(slo): Add error codes to producer failure in Rust #472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the error codes to the producer failure metric in Rust. Some new producer errors were also added that explicitly deal with producing (similar to the consumer errors).
untitaker
approved these changes
Jul 18, 2025
evanh
commented
Jul 18, 2025
| @@ -243,4 +243,20 @@ mod tests { | |||
| .produce(&destination, payload) | |||
| .expect("Message produced") | |||
| } | |||
|
|
|||
| #[test] | |||
| #[ignore = "This should fail with a KafkaError but doesn't for some reason"] | |||
There was a problem hiding this comment.
I could not figure out how to get the produce to fail. Even with a non-existent topic, referencing a partition that doesn't exist, on a broker that doesn't exist, this test still passes.
There was a problem hiding this comment.
Ah yes, @fpacifici @bmckerry found an issue with these producers: they do not await until the produce is actually done. see how the arroyo produce waits with callback+future, that's missing. maybe you can fix it in the same PR? otherwise it goes to the backlog
There was a problem hiding this comment.
Ah OK I'll see if I can fix that.
There was a problem hiding this comment.
I decided to make it a separate PR because it's not a trivial change: #473
4880a93 to
235f942
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the error codes to the producer failure metric in Rust. Some new producer errors were also
added that explicitly deal with producing (similar to the consumer errors).