Skip to content

fix(metrics): Add an error code to the produce SLO #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 18, 2025
Merged

fix(metrics): Add an error code to the produce SLO #471

merged 1 commit into from
Jul 18, 2025

Conversation

evanh
Copy link
Member

@evanh evanh commented Jul 17, 2025

If the exception is a KafkaException, add the error code to the metric produced.

@evanh
fix(metrics): Add an error code to the produce SLO
e97f607 
If the exception is a KafkaException, add the error code to the metric produced.
@evanh evanh requested review from a team as code owners July 17, 2025 19:05
@evanh
Copy link
Member Author

evanh commented Jul 17, 2025

Need to figure out rust and validate Python.

@evanh evanh changed the title WIP: fix(metrics): Add an error code to the produce SLO fix(metrics): Add an error code to the produce SLO Jul 18, 2025
@evanh evanh merged commit 989661e into main Jul 18, 2025
15 checks passed
@evanh evanh deleted the evanh/fix/add-error-codes branch July 18, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@untitaker untitaker untitaker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evanh @untitaker