fix(slo): Add a metric to capture produce success/failures for our SLO #470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a metric that counts how many successful produces there were with a status. A future PR will also add the specific error code to the tags.
untitaker
approved these changes
Jul 17, 2025
fpacifici
reviewed
Jul 17, 2025
Comment on lines
+81
to
+85
| except Exception as e: | ||
| self.__metrics.increment( | ||
| "arroyo.producer.produce_status", tags={"status": "error"} | ||
| ) | ||
| raise e |
There was a problem hiding this comment.
We need to identify the error code and add it as a tag. Not all errors should make us burn our SLO. For example messages that are too large would still show up here. Those should not make us burn the SLO.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a metric that counts how many successful produces there were with a status. A future PR
will also add the specific error code to the tags.