Skip to content

chore(deps): depend on sentry-core >=0.32 #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 3, 2025
Merged

chore(deps): depend on sentry-core >=0.32 #465

merged 3 commits into from
Jul 3, 2025

Conversation

lcian
Copy link
Member

@lcian lcian commented Jun 25, 2025 •
edited
Loading

This allows us to upgrade the SDK in crates that depend on both the SDK and arroyo itself, and not end up with two separate versions in the lockfile and at runtime.
Additionally, we just need to depend on sentry_core, as the only functionality we're using here is the Hub.

Ref getsentry/snuba#7250

@lcian lcian marked this pull request as ready for review June 30, 2025 10:58
@lcian lcian requested review from a team as code owners June 30, 2025 10:58
@untitaker
Copy link
Member

if i merge this PR and bump arroyo in a repo that doesn't have the SDK upgraded, what happens? will we just get a version split?

@lcian
Copy link
Member Author

lcian commented Jun 30, 2025

if i merge this PR and bump arroyo in a repo that doesn't have the SDK upgraded, what happens? will we just get a version split?

Yeah, the versions should be always kept in sync.

@untitaker
Copy link
Member

Yeah, the versions should be always kept in sync.

A version split would be OK. it would be worse if we cannot upgrade arroyo without upgrading the SDK.

i'd suggest to relax the version constraint anyway though

@lcian
Copy link
Member Author

lcian commented Jul 2, 2025

Yeah, the versions should be always kept in sync.

A version split would be OK. it would be worse if we cannot upgrade arroyo without upgrading the SDK.

i'd suggest to relax the version constraint anyway though

How would you suggest to relax them?

@untitaker
Copy link
Member

@lcian sentry = ">=0.32", sentry = "0.32,0.41", something like that

@lcian
Copy link
Member Author

lcian commented Jul 3, 2025

@lcian sentry = ">=0.32", sentry = "0.32,0.41", something like that

Yeah I think that's a good idea. Updated. Given that we're only using Hub::run here and that's very unlikely to change we can just go for `>= 0.32"

@lcian lcian changed the title chore(deps): bump sentry to 0.41.0 chore(deps): depend on sentry >=0.32 Jul 3, 2025
@lcian lcian changed the title chore(deps): depend on sentry >=0.32 chore(deps): depend on sentry-core >=0.32 Jul 3, 2025
@untitaker untitaker merged commit 6e3e9e2 into main Jul 3, 2025
15 checks passed
@untitaker untitaker deleted the lcian/chore/bump-sdk branch July 3, 2025 12:47
@lcian lcian mentioned this pull request Jul 7, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@untitaker untitaker untitaker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lcian @untitaker