feat: handle CPU in plan form and details #2280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR integrates Custom Pricing Units (CPU) at the plan level by introducing an appliedPricingUnit that is used for both form initialization and charge serialization/display.
- Introduces CPU handling at the plan and charge levels.
- Updates validations, serialization logic, and UI components to support pricing unit properties.
- Adds a new hook to fetch custom pricing units and updates related translations and tests.
Reviewed Changes
Copilot reviewed 25 out of 26 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| translations/base.json | Updates translation texts and adds a max-length note for pricing unit short name. |
| src/pages/settings/Invoices/CreatePricingUnit.tsx | Enhances form validation with a maximum length for shortName and adds an info alert. |
| src/pages/CreatePlan.tsx | Modifies GraphQL query to include appliedPricingUnit details. |
| src/hooks/plans/usePlanForm.tsx | Incorporates appliedPricingUnit handling in forming plan values. |
| src/hooks/plans/useCustomPricingUnits.tsx | Introduces a new hook to load custom pricing units. |
| src/formValidation/chargeSchema.ts | Updates Yup schema to validate the appliedPricingUnit fields. |
| src/core/serializers/serializePlanInput.ts | Adjusts serialization logic to conditionally include appliedPricingUnit data. |
| Other components | Modify UI components (e.g., charge tables, details sections, and input components) to display pricing unit information. |
Comments suppressed due to low confidence (1)
translations/base.json:3215
- Typo in translation text: 'shouls' should be corrected to 'should'.
"text_1750424999815o2wik8216ht": "This value shouls have a maximum length of 3 characters"
6058584 to
1c0113f
Compare
4cb2cdb to
d6901e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
CPU stands for Custom Pricing Units.
We recently added the possibility to add a custom pricing unit in the app's settings (hidden via a FE Feature Flag) #2275
We're moving forward with this feature by introducing those CPU deeper in the codebase.
Description
This PR allow to setup a CPU at the plan level.
This new CPU, once selected on a charge, is called
appliedPricingUnit.When sent to the BE it only contains
code,conversionRate. However when manipulated in the app we add extra arguments (at form init or when adding a new charge to theformikProps).Those arguments helps us determining some internal logic for display and data formatting.
shortNametypeThe 3rd commit could be hard to review but it's mostly display adjustments. All logic stands in the first 2 ones.
Happy to help for the review in any ways!
Fixes LAGO-882