fix: no hyperlinks for deleted activity type #2272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR addresses the issue of displaying hyperlinks for deleted activity types by updating query skip conditions and refactoring the logic that determines deleted activity types.
- Added a new utility function isDeletedActivityType to identify deleted activity types.
- Updated skip conditions in activity log queries to avoid hyperlink generation for deleted activity types.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/components/developers/activityLogs/ActivityLogDetails.tsx | Updated query skip conditions to include a check for deleted activity types. |
| src/components/activityLogs/utils.tsx | Introduced the isDeletedActivityType function and refactored link generation conditions accordingly. |
ansmonjol
reviewed
Jun 18, 2025
ansmonjol
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Related to: https://lago.sentry.io/issues/6581756497/?referrer=slack¬ification_uuid=537ffab5-b092-431b-80ca-0d56fce68978&environment=production&alert_rule_id=14434893&alert_type=issue